Description of problem:
User can create a product repo that contains no repourl. When user attempts to save this, save is successful, and subsequent attempts to sync produce an error. We should either disallow creation of repo w/o url, or disable sync on such repos.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Create a product, "testproduct"
2. Attempt to create a repo within "testproduct", called "testrepo" do NOT provide a repourl
3. Attempt to sync.
Error in UI
We shouldn't let users save incomplete repos OR
We should disable sync button on repos that are obviously incomplete.
[16:51] < jsherrill> cswiii: regarding https://bugzilla.redhat.com/show_bug.cgi?id=1086355, a repo with no feed makes perfect sense when uploading rpms or puppet modules directly
[16:51] < jsherrill> cswiii: however you are correct, you shouldn't be able to try to sync it
The solution for this issue should probably address multiple levels:
- server-side denial
- ui buttons disabled/hidden on product/repo pgs
Note, sync management page currently doesn't show feedless repos (as desired).
Created redmine issue http://projects.theforeman.org/issues/6651 from this bug
Moving to POST since upstream bug http://projects.theforeman.org/issues/6651 has been closed
Applied in changeset commit:katello|a06bb95372c64468af5101b3b3d67ec2630b283b.
Created attachment 925761 [details]
sync now button is greyed when no feed exists.
Tested with sat6-GA-snap4.
Now we no longer can sync repos with no feed-url as the sync button is now greyed, until we add a feed-url.
Just realized, about another scenario, where in
a) after creating a repo without a feed-url, if we move to the products page and then sync.
b) In that case it still appears like we are allowing sync of repos without feed-url.
I think the best thing would be not to allow, the users to save incomplete repos.
*** Bug 1120595 has been marked as a duplicate of this bug. ***
This was delivered with Satellite 6.0 which was released on 10 September 2014.