Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1098432

Summary:	[redhat-support-plugin-rhev] 'Red Hat Diagnose' can be submitted even without selected text
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Jiri Belka <jbelka>
Component:	redhat-support-plugin-rhev	Assignee:	Spenser Shumaker <sshumake>
Status:	CLOSED ERRATA	QA Contact:	Jiri Belka <jbelka>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.4.0	CC:	ckyrouac, dvarga, gklein, iheim, juwu, kroberts, lphiri, rbalakri, scohen, sshumake, yeylon
Target Milestone:	---
Target Release:	3.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	subeng
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-02-11 18:13:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1142923, 1156165

Description Jiri Belka 2014-05-16 08:01:32 UTC

Description of problem:
'Red Hat Diagnose' can be submitted even without selected text. The trick is to quickly double-click on the button, then it gets dark-blue color and then next submit would cause searching for Recommendations (or at least it seems so as there appears in-progress wheel icon).

This seems odd.

Version-Release number of selected component (if applicable):
redhat-support-plugin-rhev-3.4.0-4.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. go to 'Log Viewer' tab
2. login into RH Customer Portal from this ui plugin
3. do not select any host/machine but quickly double-click 'Red Hat Diagnose' button and then click on it once again

Actual results:
search is executed, 'No solutions found.' displayed in _green_ background color

Expected results:
should not work, nothing is selected as pattern for search

Additional info:

Comment 1 Spenser Shumaker 2014-06-02 15:59:18 UTC

https://github.com/redhataccess/redhat_access_angular_ui/commit/d5aeeeef77a907464a62fc2e7d3970f956b79187

Comment 2 Eyal Edri 2014-08-06 06:49:48 UTC

out of scope for 3.4.2, missing from tracker bug: [RHEV] 3.4.2 Bug tracker - https://bugzilla.redhat.com/show_bug.cgi?id=1123858.

moving to 3.4.3

Comment 4 Jiri Belka 2014-09-19 09:11:53 UTC

ok, as this button doesn't appear anymore before a log if selected - redhat-support-plugin-rhev-3.5.0-0.el6ev.noarch

Comment 5 Julie 2014-11-12 22:44:26 UTC

Hi Spenser,
If this bug requires doc text for errata release, please provide draft text in the following format:
Cause: 
Consequence: 
Fix: 
Result: 
The documentation team will review, edit, and approve the text. 
If this bug does not require doc text, please set the 'requires_doc_text' flag to -.

Comment 6 Spenser Shumaker 2014-11-14 20:12:01 UTC

Cause: The Red Hat Diagnose button could be enabled without text being selected.
Consequence: The user could diagnose an empty text string, resulting no solutions being returned.
Fix: Disable the 'Red Hat Diagnose' button when no text is selected.
Result: The user can no longer click the button when text is not selected.

Comment 7 Eyal Edri 2014-12-16 10:24:02 UTC

Spenser,
please mark the require_doc_text flag as '-' if any of these bugs needs doc for errata or ? if you need to document it and request assistance from doc team?
this is needed asap for the last rc build due this week.

Comment 9 errata-xmlrpc 2015-02-11 18:13:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0211.html