Bug 1099827 - "Create Virtual Machine"-wizard: Step 5 of 5 broken
Summary: "Create Virtual Machine"-wizard: Step 5 of 5 broken
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-05-21 09:50 UTC by Daniel Krämer
Modified: 2014-06-03 02:37 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-06-02 16:25:16 UTC
Embargoed:


Attachments (Terms of Use)
full debug output (11.97 KB, text/plain)
2014-05-21 14:40 UTC, Daniel Krämer
no flags Details
Debug output in recreating bug (10.85 KB, text/plain)
2014-05-26 19:43 UTC, kdex
no flags Details
Debug output from git repository (11.52 KB, text/plain)
2014-05-31 21:35 UTC, kdex
no flags Details
debugging patch (656 bytes, text/plain)
2014-05-31 21:42 UTC, Cole Robinson
no flags Details
Debug output, patched git version (22.00 KB, text/plain)
2014-06-01 01:53 UTC, kdex
no flags Details

Description Daniel Krämer 2014-05-21 09:50:00 UTC
Description of problem:
When creating a new VM step 5 of 5, where you can specify MAC-address, doesn't show up. Instead of this step 4 is diplayed as Step 5. When you use the "Back"-button you'll get to step 3.


Version-Release number of selected component (if applicable):
commit 0b21c96d34810ebf874d3285e80519757407073f
virt-manager-1.0.1-3.fc20.noarch

How reproducible:
always

Steps to Reproduce:
1. Connect to Debian wheezy host via ssh
2. Open "Create Virtual Machine"-wizard"
3. Choose any ISO -> "Forward"
4. Set memory and cpu as you like -> "Forward"
5. Define Storage if you like -> "Forward"

Actual results:
The wizard where you can specify network doesn't appear

Expected results:
The wizard where you specify storage appears again

Additional info:
- Mate desktop
- works fine with virt-manager-0.10.0-5.git1ffcc0cc.fc20.noarch

Comment 1 Cole Robinson 2014-05-21 13:24:21 UTC
Thanks for the report. Please reproduce with virt-manager --debug and post the output here

Comment 2 Daniel Krämer 2014-05-21 14:40:13 UTC
Created attachment 898030 [details]
full debug output

Comment 3 kdex 2014-05-26 19:39:54 UTC
I can confirm the same behavior and was just about to report this. I will provide my debug output as well.

Comment 4 kdex 2014-05-26 19:43:10 UTC
Created attachment 899355 [details]
Debug output in recreating bug

This makes VM creation impossible for me, as step 5 is essential for my setup.

Comment 5 Cole Robinson 2014-05-31 17:53:51 UTC
Both of you have a similar root issue:

  File "/usr/share/virt-manager/virtManager/create.py", line 1341, in page_changed
    self.populate_summary()
  File "/usr/share/virt-manager/virtManager/create.py", line 931, in populate_summary
    self.netdev_changed(None)
  File "/usr/share/virt-manager/virtManager/create.py", line 1086, in netdev_changed
    obj = self.conn.get_net(key)
  File "/usr/share/virt-manager/virtManager/connection.py", line 685, in get_net
    return self.nets[uuid]
KeyError: 'e195702a-4650-2fe0-4227-f408225fc369'

For one, virt-manager obviously wasn't reporting this error and the UI behaved strangely. I've now pushed a fix for that upstream.

But it doesn't explain what exactly is going wrong here, we shouldn't ever see that key error.

I've pushed an additional debugging patch to git. Can someone reproduce with latest git and post the --debug output here?

git clone git://git.fedorahosted.org/virt-manager.git
cd virt-manager
./virt-manager --debug

Comment 6 kdex 2014-05-31 21:35:44 UTC
Created attachment 901133 [details]
Debug output from git repository

Yes, I was still able to reproduce the bug. This time, on the other hand, I got stuck on page 4 of 5 (I wasn't able to move forward in the wizard).

See the attachment for more details.

Comment 7 Cole Robinson 2014-05-31 21:42:10 UTC
Created attachment 901134 [details]
debugging patch

Comment 8 Cole Robinson 2014-05-31 21:42:32 UTC
Thanks for the info. Still can't quite tell what the issue is... Can you apply the attached debugging patch to git, reproduce the issue, and post the new --debug output? Thanks a bunch

Comment 9 kdex 2014-06-01 01:53:41 UTC
Created attachment 901152 [details]
Debug output, patched git version

Sure, here's the output of the patched git version.

Comment 10 Cole Robinson 2014-06-02 16:25:16 UTC
Thank you very much for the testing and prompt responses. I've fixed the issue upstream now:

commit d3e9af832899088a17aeb44441e8316177f563ae
Author: Cole Robinson <crobinso>
Date:   Mon Jun 2 12:17:21 2014 -0400

    pollhelpers: Use correct dictionary keys for old pool/net polling (bz 109982
    
    We were inadvertently using the object name rather than UUID when libvirt
    didn't support new style polling APIs.

The reason I wasn't seeing it is because all libvirtd instances I was testing against use new style polling APIs, and our fallback path was broken in this case.

Comment 11 kdex 2014-06-03 02:37:42 UTC
Thank you very much for your quick intervention. I can't reproduce the bug anymore and thus consider the issue resolved.


Note You need to log in before you can comment on or make changes to this bug.