Bug 1100776 - Review Request: rubygem-fog-json - JSON parsing for fog providers
Summary: Review Request: rubygem-fog-json - JSON parsing for fog providers
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Josef Stribny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1100768
Blocks: 973071 1100795
TreeView+ depends on / blocked
 
Reported: 2014-05-23 12:20 UTC by Vít Ondruch
Modified: 2016-01-04 05:52 UTC (History)
4 users (show)

Fixed In Version: rubygem-fog-json-1.0.0-1.fc21
Clone Of:
Environment:
Last Closed: 2014-06-09 08:33:31 UTC
Type: ---
Embargoed:
jstribny: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Vít Ondruch 2014-05-23 12:20:16 UTC
Spec URL: http://people.redhat.com/vondruch/rubygem-fog-json.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-fog-json-1.0.0-1.fc21.src.rpm
Description: Extraction of the JSON parsing tools shared between a
number of providers in the 'fog' gem.

Fedora Account System Username: vondruch

Comment 1 Josef Stribny 2014-05-23 13:14:51 UTC
Package builds, installs, runs. Spec is written according to guidelines, rpmlint doesn't complain. Tests run and pass. I would probably start with an indefinite article ('a') on a new line in the description and there is also some trailing white space, but none of it is a serious issue => APPROVED.

Comment 2 Vít Ondruch 2014-05-23 13:23:29 UTC
Thanks for comments and review. I have fixed them locally.



New Package SCM Request
=======================
Package Name: rubygem-fog-json
Short Description: JSON parsing for fog providers
Upstream URL: http://github.com/fog/fog-json
Owners: vondruch
Branches: 
InitialCC:

Comment 3 Gwyn Ciesla 2014-05-27 13:16:29 UTC
Git done (by process-git-requests).

Comment 4 Gwyn Ciesla 2014-05-27 13:23:40 UTC
Git done (by process-git-requests).

Comment 5 Troy Dawson 2014-12-18 23:36:30 UTC
Package Change Request
======================
Package Name: rubygem-fog-json
New Branches: epel7
Owners: tdawson

Comment 6 Gwyn Ciesla 2014-12-19 13:44:33 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.