Bug 1105762 - Handbrake 0.9.9 doesn't build against libdvdnav-4.2.1
Summary: Handbrake 0.9.9 doesn't build against libdvdnav-4.2.1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libdvdnav
Version: 20
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-07 08:53 UTC by Simon Lewis
Modified: 2014-10-10 16:03 UTC (History)
4 users (show)

Fixed In Version: libdvdread-5.0.0-1.fc20
Clone Of:
Environment:
Last Closed: 2014-10-10 16:03:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch file for libdvdnav 4.2.1 (2.75 KB, patch)
2014-06-07 08:53 UTC, Simon Lewis
no flags Details | Diff
rpm spec file for configuing build and applying patch (2.08 KB, text/x-rpm-spec)
2014-06-10 16:26 UTC, Simon Lewis
no flags Details
Additional patch 1 (2.08 KB, patch)
2014-06-13 13:26 UTC, Simon Lewis
no flags Details | Diff
Additional patch 2 (408 bytes, patch)
2014-06-13 13:27 UTC, Simon Lewis
no flags Details | Diff
RPM spec file for Handbrake (6.22 KB, text/x-rpm-spec)
2014-06-17 18:38 UTC, Simon Lewis
no flags Details
additional patch for HandBrake - 1 (307 bytes, patch)
2014-06-17 18:39 UTC, Simon Lewis
no flags Details | Diff
additional patch for HandBrake - 2 (807 bytes, patch)
2014-06-17 18:40 UTC, Simon Lewis
no flags Details | Diff
additional patch for HandBrake - 3 (818 bytes, patch)
2014-06-17 18:41 UTC, Simon Lewis
no flags Details | Diff

Description Simon Lewis 2014-06-07 08:53:19 UTC
Created attachment 903087 [details]
patch file for libdvdnav 4.2.1

Description of problem:

since the update from 4.2.0 to 4.2.1 many program builds that depend on libdvdnav are broken including HandBrake

symbols are removed from latest release that can reapplied with this patch from Simone Caronni <negativo17>

Comment 1 Dominik 'Rathann' Mierzejewski 2014-06-09 20:40:13 UTC
libdvdnav 4.2.0 doesn't contain the functions in your diff. Where did you get your 4.2.0 build?

Comment 2 Simon Lewis 2014-06-10 16:26:44 UTC
Created attachment 907325 [details]
rpm spec file for configuing build and applying patch

(In reply to Dominik 'Rathann' Mierzejewski from comment #1)
> libdvdnav 4.2.0 doesn't contain the functions in your diff. Where did you
> get your 4.2.0 build?

http://dvdnav.mplayerhq.hu/releases/libdvdnav-%{version}.tar.xz


Cheers, Simon

Comment 3 Dominik 'Rathann' Mierzejewski 2014-06-11 09:56:00 UTC
$ wget http://dvdnav.mplayerhq.hu/releases/libdvdnav-4.2.0.tar.bz2
--2014-06-11 11:34:21--  http://dvdnav.mplayerhq.hu/releases/libdvdnav-4.2.0.tar.bz2
Resolving dvdnav.mplayerhq.hu (dvdnav.mplayerhq.hu)... 192.190.173.45
Connecting to dvdnav.mplayerhq.hu (dvdnav.mplayerhq.hu)|192.190.173.45|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 111575 (109K) [application/x-bzip2]
Saving to: ‘libdvdnav-4.2.0.tar.bz2’

100%[==============================================================================>] 111,575     69.5KB/s   in 1.6s   

2014-06-11 11:34:24 (69.5 KB/s) - ‘libdvdnav-4.2.0.tar.bz2’ saved [111575/111575]

$ sha256sum libdvdnav-4.2.0.tar.bz2 
8c971b08276c89ddcecd26fc44204460fd250dc57346f03476d3077188c47550  libdvdnav-4.2.0.tar.bz2
$ tar xjf libdvdnav-4.2.0.tar.bz2 
$ find libdvdnav-4.2.0/ -name "*.h" 
$ find libdvdnav-4.2.0/ -name "*.h" |xargs egrep 'dvdnav(_free)?_dup'
$ 

libdvdnav-4.2.0-5.fc20 build doesn't contain any patch to add these functions, so my conclusion is that you were running a custom build of libdvdnav package, not the one from Fedora repositories.

If you'd like to have these functions available, I can update to current git HEAD snapshot, but please stop saying that there's a regression between 4.2.0 and 4.2.1 when it isn't true.

Comment 4 Simon Lewis 2014-06-13 13:25:13 UTC
To answer your question:

If it is uesful to fedora users in general, to be able to build HandBrake-0.9.9 aggainst a stock fc20 installation, then a patch needs to be applied to libdvdnav-4.2.1.

The facts that I have determined are:

Handbrake-0.9.9 successfully builds aggainst a stock libdvdnav-4.2.0-devel as found in the fc19 repos.

HandBrake-0.9.9 does not build aggainst the stock libdvdnav-4.2.1 as found in the fc20 repos.

Handbrake-0.9.9 successfully builds aggainst a patched libdvdnav-4.2.1


As a point of reference I will attach the spec files and patches used.

Comment 5 Simon Lewis 2014-06-13 13:26:48 UTC
Created attachment 908583 [details]
Additional patch 1

Comment 6 Simon Lewis 2014-06-13 13:27:38 UTC
Created attachment 908584 [details]
Additional patch 2

Comment 7 Dominik 'Rathann' Mierzejewski 2014-06-15 21:31:03 UTC
Well, I'm happy you stopped claiming that dvdnav(_free)?_dup API was ever present in Fedora builds. Please provide build logs from failed Handbrake build or - even better - point me to the spec/source RPM you used for Handbrake and I'll try to help.

Comment 8 Simon Lewis 2014-06-17 18:37:33 UTC
Many thanks, I will attach the spec file and the necessary pathchs for HandBrake. Four sources need to be downloaded as per the spec file.

Simon

Comment 9 Simon Lewis 2014-06-17 18:38:49 UTC
Created attachment 909712 [details]
RPM spec file for Handbrake

Comment 10 Simon Lewis 2014-06-17 18:39:42 UTC
Created attachment 909713 [details]
additional patch for HandBrake - 1

Comment 11 Simon Lewis 2014-06-17 18:40:28 UTC
Created attachment 909714 [details]
additional patch for HandBrake - 2

Comment 12 Simon Lewis 2014-06-17 18:41:06 UTC
Created attachment 909715 [details]
additional patch for HandBrake - 3

Comment 13 Fedora Update System 2014-09-22 22:41:47 UTC
libdvdread-5.0.0-1.fc20, libdvdnav-5.0.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libdvdnav-5.0.1-1.fc20,libdvdread-5.0.0-1.fc20

Comment 14 Fedora Update System 2014-09-25 10:45:23 UTC
Package libdvdread-5.0.0-1.fc20, libdvdnav-5.0.1-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libdvdread-5.0.0-1.fc20 libdvdnav-5.0.1-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-11482/libdvdnav-5.0.1-1.fc20,libdvdread-5.0.0-1.fc20
then log in and leave karma (feedback).

Comment 15 Fedora Update System 2014-10-04 03:19:51 UTC
Package libdvdread-5.0.0-1.fc20, libdvdnav-5.0.1-2.20140901gite225924.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libdvdread-5.0.0-1.fc20 libdvdnav-5.0.1-2.20140901gite225924.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-11482/libdvdnav-5.0.1-2.20140901gite225924.fc20,libdvdread-5.0.0-1.fc20
then log in and leave karma (feedback).

Comment 16 Fedora Update System 2014-10-10 16:03:32 UTC
libdvdread-5.0.0-1.fc20, libdvdnav-5.0.1-2.20140901gite225924.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.