Bug 1111406 - After first save, error message is always displayed as modal panel whenever user click save in web designer
Summary: After first save, error message is always displayed as modal panel whenever u...
Keywords:
Status: CLOSED EOL
Alias: None
Product: JBoss BPMS Platform 6
Classification: Retired
Component: jBPM Designer
Version: 6.0.1
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: CR1
: 6.1.0
Assignee: Tihomir Surdilovic
QA Contact: Sona Mala
URL:
Whiteboard:
: 1026965 1075077 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-20 01:02 UTC by Hisao Furuichi
Modified: 2020-03-27 20:09 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-03-27 20:09:26 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBPM-4371 0 Major Closed After first save, error message is always displayed as modal panel whenever user click save in web designer 2016-07-16 07:59:32 UTC

Description Hisao Furuichi 2014-06-20 01:02:12 UTC 
Description of problem:
In designer, user can save bpmn2 without any ERROR message at first time. From the 2nd time, every time user saves it, error message is displayed as modal panel. The error pop-up says:
==
User admin has updated the following resource default://master@repository1/project3/src/main/resources/TestProcess.bpmn2.
==

Steps to Reproduce:
1. Open designer in business-central
2. save business process
3. save it again

Actual results:
error pop-up is displayed

Expected results:
no error message will be displayed
Comment 1 Pedro Zapata 2014-09-30 14:43:54 UTC 
This issue is important to fix since it's currently affecting the Freemodeler project as well.
Comment 2 Jeremy Lindop 2014-11-11 12:16:17 UTC 
Branch - 6.2.x
https://github.com/droolsjbpm/jbpm-designer/commit/367862e861a637e5fb2e26558352a07b998acfc7

Branch - master
https://github.com/droolsjbpm/jbpm-designer/commit/c3f7b505f17e6edaddbaf97528f96360bb4431a4

Fixed by resetting concurrentUpdateSessionInfo in DesignerPresenter after each save.
Comment 3 Jeremy Lindop 2014-11-14 11:15:57 UTC 
Branch - 6.2.x
https://github.com/droolsjbpm/jbpm-designer/commit/97d02c3975c06a0003a22e5431339a74d271a0df

Branch - master
https://github.com/droolsjbpm/jbpm-designer/commit/e8fda3d4f3b9f402c024a094cd34b6557ca4f531

Previous fix was unreliable because events involved are asynchronous. Fixed by making DesignerPresenter ignore the ConcurrentUpdateEvent trigger by its own save.
Comment 4 Jeremy Lindop 2014-11-19 13:26:03 UTC 
*** Bug 1026965 has been marked as a duplicate of this bug. ***
Comment 5 Jeremy Lindop 2014-11-19 13:31:55 UTC 
*** Bug 1075077 has been marked as a duplicate of this bug. ***
Comment 6 Sona Mala 2014-12-15 14:26:41 UTC 
It seems that resolving of conflicts works fine in ER3.
Comment 7 Sona Mala 2015-01-13 15:02:11 UTC 
The user can modify the process how manytimes he or she wants. If he or she works alone on process.

The conflict dialog is displayed when the user have already modified the process and someone pushes changes.
Comment 8 Sona Mala 2015-03-02 07:47:51 UTC 
This issue is present in 6.1.0 ER5. Look at bz 1184487.
Comment 9 Jeremy Lindop 2015-03-02 17:20:41 UTC 
Fixed for 6.2.0 - see https://bugzilla.redhat.com/show_bug.cgi?id=1184487
Comment 10 Sona Mala 2015-03-03 06:43:09 UTC 
This is a custom issue and it was fixed in 6.1.0 ER3. Is a problem to cherry pick this fix to 6.1.0?
Comment 11 Jeremy Lindop 2015-03-03 11:54:03 UTC 
I think cherry-picking the commit from https://bugzilla.redhat.com/show_bug.cgi?id=1184487#c3 to the 6.2.x branch should work.
Comment 12 Jeremy Lindop 2015-03-04 13:56:02 UTC 
Commit cherry-piked to 6.2.x branch.
See https://bugzilla.redhat.com/show_bug.cgi?id=1184487#c4
Comment 13 Sona Mala 2015-03-30 07:39:40 UTC 
This issue was verified on 6.1.0 CR1.

The conflict dialog is not shown when one user works with a BP.
Comment 15 JBoss JIRA Server 2016-07-16 07:59:32 UTC 
Jozef Marko <jomarko> updated the status of jira JBPM-4371 to Closed
Note You need to log in before you can comment on or make changes to this bug.