Bug 1112378 - oo-accept-node ignores OPENSHIFT_CGROUP_SUBSYSTEMS config
Summary: oo-accept-node ignores OPENSHIFT_CGROUP_SUBSYSTEMS config
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Jhon Honce
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1112448
TreeView+ depends on / blocked
 
Reported: 2014-06-23 19:14 UTC by Andy Grimm
Modified: 2016-11-08 03:47 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1112448 (view as bug list)
Environment:
Last Closed: 2014-10-10 00:47:56 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Andy Grimm 2014-06-23 19:14:45 UTC
Description of problem:

oo-accept-node will fail with "user <UUID> must have all cgroup subsystems" if the set of cgroup subsystems differs from the default list.

Version-Release number of selected component (if applicable):

openshift-origin-node-util-1.25.5-1.el6oso.noarch

How reproducible:

Always

Steps to Reproduce:
1. Set OPENSHIFT_CGROUP_SUBSYSTEMS=cpu,cpuacct,memory,net_cls,freezer,blkio
2. oo-cgroup-enable --with-all-containers
3. run oo-accept-node -v

Actual results:

"user <UUID> must have all cgroup subsystems" for all users

Expected results:

PASS

Comment 1 Andy Grimm 2014-06-23 19:32:19 UTC
PR filed:

https://github.com/openshift/origin-server/pull/5545

There's a merge conflict, though I cannot see how...

Comment 2 Adam Miller 2014-06-23 21:07:51 UTC
I spoke with tdawson and he said he didn't believe this to be a blocker for the 2.0.46 release so I tagged it UpcomingRelease

Feel free to switch that if you think that it should in fact be a release blocker.

Comment 3 Luke Meyer 2014-07-08 19:51:45 UTC
Looks like the merge conflict went away. Per agrimm seems ready to merge.

Comment 4 openshift-github-bot 2014-07-08 20:34:00 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/9017a2a4fd2c4ffde6ec1320680364efaf1d2a71
Bug 1112378 - Respect OPENSHIFT_CGROUP_SUBSYSTEMS in oo-accept-node

Comment 5 Meng Bo 2014-07-10 07:16:55 UTC
Checked on devenv_4955, issue has been fixed.

1. Set the OPENSHIFT_CGROUP_SUBSYSTEMS=cpu,cpuacct,memory,net_cls,freezer,blkio in node.conf
2. Mount the blkio from /etc/cgconfig.conf
3. service cgconfig restart
4. oo-cgroup-enable -a
5. oo-accept-node -v

Will not report the error.


Note You need to log in before you can comment on or make changes to this bug.