Bug 1112448 - oo-accept-node ignores OPENSHIFT_CGROUP_SUBSYSTEMS config
Summary: oo-accept-node ignores OPENSHIFT_CGROUP_SUBSYSTEMS config
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Containers
Version: 2.1.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Luke Meyer
QA Contact: libra bugs
URL:
Whiteboard:
Depends On: 1112378
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-24 01:50 UTC by Brenton Leanhardt
Modified: 2014-08-04 13:27 UTC (History)
10 users (show)

Fixed In Version: openshift-origin-node-util-1.22.10.1-1.el6op
Doc Type: Bug Fix
Doc Text:
The oo-accept-node script compared the list of cgroup subsystems in use against a hard-coded, default list. However, a custom list could be set using the OPENSHIFT_CGROUP_SUBSYSTEMS parameter in the /etc/openshift/node.conf file. When a custom list was in use, the script failed when the custom list differed from the hard-coded, default list. This bug fix updates the oo-accept -node script to make these comparisons using the custom list in the OPENSHIFT_CGROUP_SUBSYSTEMS parameter, if set, and the script no longer fails in this way.
Clone Of: 1112378
Environment:
Last Closed: 2014-08-04 13:27:31 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:0999 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.1.4 bug fix and enhancement update 2014-08-04 17:26:43 UTC

Description Brenton Leanhardt 2014-06-24 01:50:58 UTC
+++ This bug was initially created as a clone of Bug #1112378 +++

Description of problem:

oo-accept-node will fail with "user <UUID> must have all cgroup subsystems" if the set of cgroup subsystems differs from the default list.

Version-Release number of selected component (if applicable):

openshift-origin-node-util-1.25.5-1.el6oso.noarch

How reproducible:

Always

Steps to Reproduce:
1. Set OPENSHIFT_CGROUP_SUBSYSTEMS=cpu,cpuacct,memory,net_cls,freezer,blkio
2. oo-cgroup-enable --with-all-containers
3. run oo-accept-node -v

Actual results:

"user <UUID> must have all cgroup subsystems" for all users

Expected results:

PASS

--- Additional comment from Andy Grimm on 2014-06-23 15:32:19 EDT ---

PR filed:

https://github.com/openshift/origin-server/pull/5545

There's a merge conflict, though I cannot see how...

--- Additional comment from Adam Miller on 2014-06-23 17:07:51 EDT ---

I spoke with tdawson and he said he didn't believe this to be a blocker for the 2.0.46 release so I tagged it UpcomingRelease

Feel free to switch that if you think that it should in fact be a release blocker.

Comment 1 Luke Meyer 2014-07-08 19:50:52 UTC
Check this after upstream fix has been QEed.

Comment 2 Luke Meyer 2014-07-10 15:40:11 UTC
https://github.com/openshift/enterprise-server/pull/317

cherry-picking this fix:

commit 9017a2a4fd2c4ffde6ec1320680364efaf1d2a71
Author: Andy Grimm <agrimm>
Date:   Mon Jun 23 15:24:23 2014 -0400

    Bug 1112378 - Respect OPENSHIFT_CGROUP_SUBSYSTEMS in oo-accept-node

Comment 4 Yanping Zhang 2014-07-15 06:31:53 UTC
Verified on OpenShiftEnterpriseErrata/2.1.z/2014-07-14.1

Steps to verify:
1. Create an app on the test node first, and set the OPENSHIFT_CGROUP_SUBSYSTEMS=cpu,cpuacct,memory,net_cls,freezer,blkio in node.conf
2. Mount the blkio from /etc/cgconfig.conf
3. service cgconfig restart
4. oo-cgroup-enable -a
5. oo-accept-node -v
Actual results:
5.[root@node1 ~]# oo-accept-node -v
INFO: using default accept-node extensions
INFO: loading node configuration file /etc/openshift/node.conf
INFO: loading resource limit file /etc/openshift/resource_limits.conf
INFO: finding external network device
INFO: checking node public hostname resolution
INFO: checking selinux status
INFO: checking selinux openshift-origin policy
INFO: checking selinux booleans
INFO: checking package list
INFO: checking services
INFO: checking kernel semaphores >= 512
INFO: checking cgroups configuration
INFO: checking cgroups processes
INFO: find district uuid: 53c47286db26c8d0e8000001
INFO: determining node uid range: 1000 to 6999
INFO: traffic control not enabled in /etc/openshift/node.conf, set TRAFFIC_CONTROL_ENABLED=true to enable
INFO: checking filesystem quotas
INFO: checking quota db file selinux label
INFO: checking 1 user accounts
INFO: checking application dirs
INFO: checking system httpd configs
INFO: checking cartridge repository
PASS

Comment 6 errata-xmlrpc 2014-08-04 13:27:31 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0999.html


Note You need to log in before you can comment on or make changes to this bug.