Bug 1114242 - OVIRT35 - [RFE] Admin GUI: Sort by 'IP address' (in VM tab) should not treat the IP address as a string
Summary: OVIRT35 - [RFE] Admin GUI: Sort by 'IP address' (in VM tab) should not treat ...
Keywords:
Status: CLOSED DUPLICATE of bug 1114244
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-webadmin-portal
Version: 3.3.0
Hardware: All
OS: Windows
low
medium
Target Milestone: ---
: 3.5.0
Assignee: Lior Vernia
QA Contact: Meni Yakove
URL:
Whiteboard: network
Depends On: 590413 893999 1114244
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-29 07:36 UTC by Lior Vernia
Modified: 2016-02-10 19:47 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of: 590413
Environment:
Last Closed: 2014-06-29 07:47:57 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 28272 0 None None None Never

Description Lior Vernia 2014-06-29 07:36:25 UTC
+++ This bug was initially created as a clone of Bug #590413 +++

Description of problem:
If I click on the VMs tab on the 'IP address' header, the sort is done as if it was a text field:
10.35.113.9
10.35.113.30
10.35.113.3
10.35.113.16

where one would expect the order to be:
10.35.113.30
10.35.113.16
10.35.113.9
10.35.113.3


Version-Release number of selected component (if applicable):
sm62

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

--- Additional comment from Yaniv Kaul on 2010-05-09 10:06:14 EDT ---

I thought it was a bug.
And Max reminded me that also the name sort is not done quite correctly. It should be done in 'natural' order (http://www.codinghorror.com/blog/2007/12/sorting-for-humans-natural-sort-order.html)

--- Additional comment from Itamar Heim on 2012-01-05 05:54:21 EST ---

not sure if this should be fixed at UI level or search sort level

--- Additional comment from Lior Vernia on 2012-12-30 08:13:24 EST ---

As far as I can see, the IP header is not clickable (anymore?) so the bug is irrelevant (or maybe just obsolete). Yaniv?

--- Additional comment from Yaniv Kaul on 2012-12-30 08:46:31 EST ---

(In reply to comment #3)
> As far as I can see, the IP header is not clickable (anymore?) so the bug is
> irrelevant (or maybe just obsolete). Yaniv?

There should be a bug that in the move from the old UI to the old one we've lost all sorting per headers :(
Einav?

--- Additional comment from Einav Cohen on 2013-01-10 08:56:49 EST ---

(In reply to comment #4)
> (In reply to comment #3)
> > As far as I can see, the IP header is not clickable (anymore?) so the bug is
> > irrelevant (or maybe just obsolete). Yaniv?
> 
> There should be a bug that in the move from the old UI to the old one we've
> lost all sorting per headers :(
> Einav?

That's right - when solving bug 893999, need to keep this bug in mind -> putting bug 893999 as a blocker to this one.

--- Additional comment from Einav Cohen on 2013-01-10 09:47:14 EST ---

(In reply to comment #2)
> not sure if this should be fixed at UI level or search sort level

as long as the UI sort and the backend sort are not "connected" - it should be fixed in both (assuming the search-language allows sorting according to ip-address), in order to prevent inconsistent behavior.

worth considering consolidating the two, maybe in the context of blocking bug 893999.

--- Additional comment from Sven Kieske on 2014-04-25 11:04:00 EDT ---

I'm not sure this one should be closed yet?

--- Additional comment from Lior Vernia on 2014-04-27 03:05:17 EDT ---

Well, it's basically fixed. The bug blocking this is about to be fixed, while the backend sorting by IP had been fixed as part of Bug 895468. So whenever the blocker bug is fixed, this could be moved to ON_QA for verification, or alternatively forgotten :)

--- Additional comment from Lior Vernia on 2014-05-28 09:15:57 EDT ---

Sven, I was actually too quick to respond, you're right and this should be reopened - there's still a little wiring missing for this to work by clicking on the column header.

Comment 1 Lior Vernia 2014-06-29 07:47:57 UTC
Opened by accident.

*** This bug has been marked as a duplicate of bug 1114244 ***


Note You need to log in before you can comment on or make changes to this bug.