Description of problem: Version-Release number of selected component (if applicable): ovirt-engine-backend-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch How reproducible: always Steps to Reproduce: 1. add more domains to engine. 2. check how they are sorted in login dialog. Actual results: random Expected results: alphabetically sorted Additional info:
I think there is some logic of what's the last domain you chose. Einav - any clue about that?
(In reply to Oved Ourfali from comment #1) > I think there is some logic of what's the last domain you chose. > Einav - any clue about that? not sure, but in any case - the last domain you chose is affecting only the selected item, not the order of all of the items in the drop-down. [the automatically-selected item is not necessarily the first one in the drop down - you can have in the drop down 'domain1', 'domain2' and 'domain3', and 'domain2' (i.e. the second item in the drop-down) will be selected by default, (since it is the lastly selected or similar) - however, this BZ is about 'domain1', 'domain2' and 'domain3' not being alphabetically ordered, regardless of the selected item].
Hi, I can see a commit[1] from 15/01/14 adding sorting (a-b ascending, 'internal' always last). I tested master and indeed domains are sorted at login screen.
[1] http://gerrit.ovirt.org/#/c/20412/33/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java,cm
The GetDomainList query isn't now used by the GUI, only by the RESTAPI. The GUI uses now GetAAAProfileList.
I can see that now, thanks. Looks like a change in needed in light of comment 5.
(In reply to Mooli Tayer from comment #6) > I can see that now, thanks. > > Looks like a change in needed in light of comment 5. yes, I think it was a mistake sort() was not done at the get profile list. but we should remove the internal exception in sort at all cases, there is no reason to do so. thanks for the patch! but I think yair should be assigned or at least be CCed to any AAA change.
(In reply to Juan Hernández from comment #5) > The GetDomainList query isn't now used by the GUI, only by the RESTAPI. The > GUI uses now GetAAAProfileList. So should REST use the new query as well?
(In reply to Oved Ourfali from comment #8) > (In reply to Juan Hernández from comment #5) > > The GetDomainList query isn't now used by the GUI, only by the RESTAPI. The > > GUI uses now GetAAAProfileList. > > So should REST use the new query as well? no, rest is listing the directories (authz) not the profiles.
pending 3.5 backport.
ok, ovirt-engine-backend-3.5.0-0.0.master.20140804172041.git23b558e.el6.noarch domains are listed alphabetically.
oVirt 3.5 has been released and should include the fix for this issue.