Spec URL: http://ralph.fedorapeople.org//nodejs-saucelabs.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-saucelabs-0.1.1-1.fc20.src.rpm Description: node-saucelabs ========
Some comments: - Empty debug package is created. - BuildArch: noarch needs to be specified, eg: BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif - %description can be improved, e.g. make it %{summary}. - %nodejs_symlink_deps --build can be ommited in %{build} I can do a full review later this week when you fix those issues.
Hi Piotr, thanks! I made some changes, but not all. To explain: - Empty debug package is created. - noarch took care of this: http://koji.fedoraproject.org/koji/taskinfo?taskID=8220043 - BuildArch: noarch needs to be specified, eg: BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif - Agreed -- done! - %description can be improved, e.g. make it %{summary}. - Agreed -- done! - %nodejs_symlink_deps --build can be ommited in %{build} - I'd like to leave this, even if it is a no-op, so that it stays symmetric with my other node packages. -- A new release of the package with the changes above can be found here: Spec URL: http://threebean.org/rpm/SPECS/nodejs-saucelabs.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-saucelabs-0.1.1-2.fc20.src.rpm
Great! I will try to do a full review this evening. You could also check https://bugzilla.redhat.com/show_bug.cgi?id=1115679 too, Think I saw the missing arch there as well,
Summary: APPROVED. Two fails in should section: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: %check is present and all tests pass. I've tried to package the dependencies required, but it seems there is one dependency (jshint) which has an incompatible licence (use for good, not evil) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/nodejs-saucelabs/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: nodejs-saucelabs-0.1.1-2.fc21.noarch.rpm nodejs-saucelabs-0.1.1-2.fc21.src.rpm nodejs-saucelabs.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-saucelabs nodejs-saucelabs.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-saucelabs (rpmlib, GLIBC filtered): nodejs(engine) Provides -------- nodejs-saucelabs: nodejs-saucelabs npm(saucelabs) Source checksums ---------------- http://registry.npmjs.org/saucelabs/-/saucelabs-0.1.1.tgz : CHECKSUM(SHA256) this package : fe7d1505af4e134ee91d037b9daf69ab374b02acc9371d119f6fbfd6c74debc6 CHECKSUM(SHA256) upstream package : fe7d1505af4e134ee91d037b9daf69ab374b02acc9371d119f6fbfd6c74debc6 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review --rpm-spec -n SRPMS/nodejs-saucelabs-0.1.1-2.fc21.src.rpm Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thanks Piotr! New Package SCM Request ======================= Package Name: nodejs-saucelabs Short Description: A wrapper around Sauce Labs REST API Upstream URL: https://www.npmjs.org/package/saucelabs Owners: ralph Branches: f21 f20 f19 epel7 InitialCC:
Git done (by process-git-requests).
Built for rawhide.
nodejs-saucelabs-0.1.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-saucelabs-0.1.1-2.fc21
nodejs-saucelabs-0.1.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-saucelabs-0.1.1-2.fc20
nodejs-saucelabs-0.1.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-saucelabs-0.1.1-2.fc19
nodejs-saucelabs-0.1.1-2.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-saucelabs-0.1.1-2.fc19 has been pushed to the Fedora 19 stable repository.
nodejs-saucelabs-0.1.1-2.fc20 has been pushed to the Fedora 20 stable repository.