Spec URL: http://ralph.fedorapeople.org//nodejs-grunt-saucelabs.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-grunt-saucelabs-8.1.0-1.fc20.src.rpm Description: A Grunt task for running QUnit, Jasmine, Mocha, YUI tests, or any framework using Sauce Labs' Cloudified Browsers.
Some comments: - Please update to latest upstream release if possible. - Are following BuildRequires needed? If so could add a comment explaining why, there is nothing being built. If they are needed for tests put them in the %if 0%{?enable_tests} conditional. BuildRequires: nodejs-saucelabs BuildRequires: nodejs-q BuildRequires: nodejs-colors BuildRequires: nodejs-lodash BuildRequires: nodejs-sauce-tunnel BuildRequires: nodejs-grunt BuildRequires: nodejs-request - You can leave out following "Requires:" they should be handled automatically, see: https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Automatic_Requires_and_Provides If automatic requires don't work, please add an comment explaining. Requires: nodejs-saucelabs Requires: nodejs-q Requires: nodejs-colors Requires: nodejs-lodash Requires: nodejs-sauce-tunnel Requires: nodejs-grunt Requires: nodejs-request - Add the buildarch noarch as you did in nodejs-saucelabs - Could you explain why the %nodejs_fixdep are needed?
Sure thing! Latest upstream: Spec URL: http://threebean.org/rpm/SPECS/nodejs-grunt-saucelabs.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-grunt-saucelabs-8.3.3-1.fc20.src.rpm
Great, looks fine now: APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 89 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/nodejs-grunt- saucelabs/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Installation errors ------------------- INFO: mock.py version 1.1.41 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.41 INFO: Mock Version: 1.1.41 Start: lock buildroot INFO: installing package(s): /home/piotr/rpmbuild/nodejs-grunt-saucelabs/results/nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-21-x86_64/root/', '--releasever', '21', 'install', '/home/piotr/rpmbuild/nodejs-grunt-saucelabs/results/nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch (/nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch) Requires: npm(sauce-tunnel) < 2.2 You could try using --skip-broken to work around the problem Error: Package: nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch (/nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch) Requires: npm(sauce-tunnel) >= 2.1.0 Error: Package: nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch (/nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch) Requires: npm(saucelabs) >= 0.1.1 Error: Package: nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch (/nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch) Requires: npm(saucelabs) < 0.2 You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: nodejs-grunt-saucelabs-8.3.3-1.fc21.noarch.rpm nodejs-grunt-saucelabs-8.3.3-1.fc21.src.rpm nodejs-grunt-saucelabs.noarch: W: only-non-binary-in-usr-lib nodejs-grunt-saucelabs.noarch: W: dangling-symlink /usr/lib/node_modules/grunt-saucelabs/node_modules/saucelabs /usr/lib/node_modules/saucelabs nodejs-grunt-saucelabs.noarch: W: dangling-symlink /usr/lib/node_modules/grunt-saucelabs/node_modules/q /usr/lib/node_modules/q nodejs-grunt-saucelabs.noarch: W: dangling-symlink /usr/lib/node_modules/grunt-saucelabs/node_modules/colors /usr/lib/node_modules/colors nodejs-grunt-saucelabs.noarch: W: dangling-symlink /usr/lib/node_modules/grunt-saucelabs/node_modules/request /usr/lib/node_modules/request nodejs-grunt-saucelabs.noarch: W: dangling-symlink /usr/lib/node_modules/grunt-saucelabs/node_modules/sauce-tunnel /usr/lib/node_modules/sauce-tunnel nodejs-grunt-saucelabs.noarch: W: dangling-symlink /usr/lib/node_modules/grunt-saucelabs/node_modules/lodash /usr/lib/node_modules/lodash 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Requires -------- nodejs-grunt-saucelabs (rpmlib, GLIBC filtered): nodejs(engine) npm(colors) npm(lodash) npm(q) npm(request) npm(sauce-tunnel) npm(saucelabs) Provides -------- nodejs-grunt-saucelabs: nodejs-grunt-saucelabs npm(grunt-saucelabs) Source checksums ---------------- http://registry.npmjs.org/grunt-saucelabs/-/grunt-saucelabs-8.3.3.tgz : CHECKSUM(SHA256) this package : a6182789bfa871f43cde060cfbb596ba8f0ac4df40d43ab36e530f454679e028 CHECKSUM(SHA256) upstream package : a6182789bfa871f43cde060cfbb596ba8f0ac4df40d43ab36e530f454679e028 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review --rpm-spec -n SRPMS/nodejs-grunt-saucelabs-8.3.3-1.fc21.src.rpm Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
PS. Would you mind taking a look at this review-request? https://bugzilla.redhat.com/show_bug.cgi?id=1164496
New Package SCM Request ======================= Package Name: nodejs-grunt-saucelabs Short Description: Grunt task running tests using Sauce Labs Upstream URL: https://npmjs.org/package/grunt-saucelabs Owners: ralph Branches: f21,f20,f19,epel7 InitialCC:
Git done (by process-git-requests).
Built for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8277456
nodejs-grunt-saucelabs-8.3.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-grunt-saucelabs-8.3.3-1.fc21
nodejs-grunt-saucelabs-8.3.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-grunt-saucelabs-8.3.3-1.fc20
nodejs-grunt-saucelabs-8.3.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-grunt-saucelabs-8.3.3-1.fc19
nodejs-grunt-saucelabs-8.3.3-1.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-grunt-saucelabs-8.3.3-1.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-grunt-saucelabs-8.3.3-1.fc19 has been pushed to the Fedora 19 stable repository.