In NFS storage domains we validate that the following custom mount options are NOT specified since they are already managed and specified automatically:
timeo, retrans, vfs_type, protocol_version, nfsvers, vers, minorversion, addr, clientaddr
For Posix storage domains:
vfs_type, addr, clientaddr
Created attachment 914955[details]
logs
Description of problem:
We can set illegal NFS mount advanced parameters which are ignored and we are not aware of it.
Version-Release number of selected component (if applicable):
ovirt 3.5 beta
How reproducible:
100%
Steps to Reproduce:
1. Create NFS SD with advanced parameter Retransmissions=A
2.
3.
Actual results:
We do not get any warning nor blocked with CanDoaction, mount succeed with default value
Expected results:
We should get warning about setting default value instead of the wrong one or we should be blocked.
Additional info:
By design, engine does NOT parse mount options, as the entire point of this feature is to allow vendor specific configurations. Having the engine parse these options will, by design, mean that the engine limits the values you may pass. So this cannot be handled in a CDA.
However, I fail to understand why VDSM doesn't fail with an "an incorrect mount option was specified".
"retrans" to be precise, but it doesn't block you from specifying non managed NFS options with an incorrect value, although as stated those options should probably not and more likely can't be parsed and validated
So this is not a bug - closing.
Please add the doctext to specify what validations we DO handle, and what we leave to the mount command to handle (or ignore)
Created attachment 914955 [details] logs Description of problem: We can set illegal NFS mount advanced parameters which are ignored and we are not aware of it. Version-Release number of selected component (if applicable): ovirt 3.5 beta How reproducible: 100% Steps to Reproduce: 1. Create NFS SD with advanced parameter Retransmissions=A 2. 3. Actual results: We do not get any warning nor blocked with CanDoaction, mount succeed with default value Expected results: We should get warning about setting default value instead of the wrong one or we should be blocked. Additional info: