Spec URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-2/python-inflect.spec SRPM URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-2/python-inflect-0.2.4-2.fc21.src.rpm Description: The methods of the class 'engine' in module 'inflect.py' provide plural inflections, singular noun inflections, "a"/"an" selection for English words, and manipulation of numbers as words. Plural forms of all nouns, most verbs, and some adjectives are provided. Where appropriate, "classical" variants (for example: "brother" -> "brethren", "dogma" -> "dogmata", etc.) are also provided. Single forms of nouns are also provided. The gender of singular pronouns can be chosen (for example "they" -> "it" or "she" or "he" or "they"). Pronunciation-based "a"/"an" selection is provided for all English words, and most initialisms. It is also possible to inflect numerals (1,2,3) to ordinals (1st, 2nd, 3rd) and to english words ("one", "two", "three). Fedora Account System Username: dshea
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 26 files have unknown license. Detailed output of licensecheck in /run/media/jenselme/Data/1117482-python-inflect/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 6 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-inflect [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-inflect-0.2.4-2.fc20.noarch.rpm python3-inflect-0.2.4-2.fc20.noarch.rpm python-inflect-0.2.4-2.fc20.src.rpm python-inflect.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-inflect.noarch: W: spelling-error %description -l en_US dogmata -> dogma ta, dogma-ta, dogmatic python-inflect.noarch: W: spelling-error %description -l en_US initialisms -> initial isms, initial-isms, initializes python-inflect.noarch: W: spelling-error %description -l en_US english -> English python-inflect.noarch: W: incoherent-version-in-changelog 0.2.4-1 ['0.2.4-2.fc20', '0.2.4-2'] python3-inflect.noarch: W: spelling-error %description -l en_US py -> pt, p, y python3-inflect.noarch: W: spelling-error %description -l en_US dogmata -> dogma ta, dogma-ta, dogmatic python3-inflect.noarch: W: spelling-error %description -l en_US initialisms -> initial isms, initial-isms, initializes python3-inflect.noarch: W: spelling-error %description -l en_US english -> English python-inflect.src: W: spelling-error %description -l en_US py -> pt, p, y python-inflect.src: W: spelling-error %description -l en_US dogmata -> dogma ta, dogma-ta, dogmatic python-inflect.src: W: spelling-error %description -l en_US initialisms -> initial isms, initial-isms, initializes python-inflect.src: W: spelling-error %description -l en_US english -> English 3 packages and 0 specfiles checked; 0 errors, 13 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-inflect python3-inflect python-inflect.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-inflect.noarch: W: spelling-error %description -l en_US dogmata -> dogma ta, dogma-ta, dogmatic python-inflect.noarch: W: spelling-error %description -l en_US initialisms -> initial isms, initial-isms, initializes python-inflect.noarch: W: spelling-error %description -l en_US english -> English python-inflect.noarch: W: incoherent-version-in-changelog 0.2.4-1 ['0.2.4-2.fc20', '0.2.4-2'] python3-inflect.noarch: W: spelling-error %description -l en_US py -> pt, p, y python3-inflect.noarch: W: spelling-error %description -l en_US dogmata -> dogma ta, dogma-ta, dogmatic python3-inflect.noarch: W: spelling-error %description -l en_US initialisms -> initial isms, initial-isms, initializes python3-inflect.noarch: W: spelling-error %description -l en_US english -> English 2 packages and 0 specfiles checked; 0 errors, 9 warnings. # echo 'rpmlint-done:' Requires -------- python-inflect (rpmlib, GLIBC filtered): python(abi) python3-inflect (rpmlib, GLIBC filtered): python(abi) Provides -------- python-inflect: python-inflect python3-inflect: python3-inflect Source checksums ---------------- https://pypi.python.org/packages/source/i/inflect/inflect-0.2.4.tar.gz : CHECKSUM(SHA256) this package : be63ed78f8da783be74cb02ae261e1f9cf4ea2c60cbf2f91862e1429c7011c89 CHECKSUM(SHA256) upstream package : be63ed78f8da783be74cb02ae261e1f9cf4ea2c60cbf2f91862e1429c7011c89 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1117482 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG In the description, you should capitaze the last "english". The others rpmlint spelling checked errors need no attention. Regards,
I guess that'll teach me to copy and paste a description without looking at it. Spec URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-3/python-inflect.spec SRPM URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-3/python-inflect-0.2.4-3.fc22.src.rpm
Approved!
Error on my part. Please separate python2 and python3 requires, ie put the python3 dependencies like this: %package -n python3-inflect Summary: Correctly generate plurals, singular nouns, ordinals and indefinite articles BuildRequires: python3-devel, python3-nose, python3-setuptools
Spec URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-4/python-inflect.spec SRPM URL: http://dshea.fedorapeople.org/python-inflect/0.2.4-4/python-inflect-0.2.4-4.fc22.src.rpm
New Package SCM Request ======================= Package Name: python-inflect Short Description: Correctly generate plurals, singular nouns, ordinals and indefinite articles Upstream URL: https://pypi.python.org/pypi/inflect Owners: dshea Branches: f20 f21 InitialCC:
Git done (by process-git-requests).
python-inflect-0.2.4-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-inflect-0.2.4-4.fc20
python-inflect-0.2.4-4.fc20 has been pushed to the Fedora 20 testing repository.
python-inflect-0.2.4-4.fc20 has been pushed to the Fedora 20 stable repository.