Bug 1117483 - Review Request: python-jinja2_pluralize - Jinja2 pluralize filters
Summary: Review Request: python-jinja2_pluralize - Jinja2 pluralize filters
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Julien Enselme
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1117482
Blocks: 1082656
TreeView+ depends on / blocked
 
Reported: 2014-07-08 19:18 UTC by David Shea
Modified: 2014-08-15 02:34 UTC (History)
2 users (show)

Fixed In Version: python-jinja2_pluralize-0.2.1-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-15 02:34:55 UTC
Type: ---
Embargoed:
jujens: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description David Shea 2014-07-08 19:18:05 UTC
Spec URL: http://dshea.fedorapeople.org/python-jinja2_pluralize/0.2.0-1/python-jinja2_pluralize.spec
SRPM URL: http://dshea.fedorapeople.org/python-jinja2_pluralize/0.2.0-1/python-jinja2_pluralize-0.2.0-1.fc21.src.rpm

Description:
Simple pluralize filter for jinja2 based on inflect.py

Fedora Account System Username: dshea

Comment 1 Julien Enselme 2014-07-21 16:11:03 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


===== MUST items =====

Generic:
[X]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[X]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 10 files have unknown license. Detailed output of
     licensecheck in /run/media/jenselme/Data/1117483-python-
     jinja2_pluralize/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 10 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build process.
[X]: A package which is used by another package via an egg interface should
     provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[X]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-jinja2_pluralize
[X]: Package functions as described.
[!]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[X]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
     architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
No handlers could be found for logger "trace.__main__"
INFO: mock.py version 1.1.39 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.39
INFO: Mock Version: 1.1.39
Start: lock buildroot
INFO: installing package(s): /run/media/jenselme/Data/1117483-python-jinja2_pluralize/results/python-jinja2_pluralize-0.2.0-1.fc20.noarch.rpm /run/media/jenselme/Data/1117483-python-jinja2_pluralize/results/python3-jinja2_pluralize-0.2.0-1.fc20.noarch.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-20-x86_64/root/', '--releasever', '20', 'install', '/run/media/jenselme/Data/1117483-python-jinja2_pluralize/results/python-jinja2_pluralize-0.2.0-1.fc20.noarch.rpm', '/run/media/jenselme/Data/1117483-python-jinja2_pluralize/results/python3-jinja2_pluralize-0.2.0-1.fc20.noarch.rpm', '--setopt=tsflags=nocontexts']
Error: Package: python-jinja2_pluralize-0.2.0-1.fc20.noarch (/python-jinja2_pluralize-0.2.0-1.fc20.noarch)
           Requires: python3-inflect
 You could try using --skip-broken to work around the problem
Error: Package: python-jinja2_pluralize-0.2.0-1.fc20.noarch (/python-jinja2_pluralize-0.2.0-1.fc20.noarch)
           Requires: python-inflect
 You could try running: rpm -Va --nofiles --nodigest



Rpmlint
-------
Checking: python-jinja2_pluralize-0.2.0-1.fc20.noarch.rpm
          python3-jinja2_pluralize-0.2.0-1.fc20.noarch.rpm
          python-jinja2_pluralize-0.2.0-1.fc20.src.rpm
python-jinja2_pluralize.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python3-jinja2_pluralize.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python-jinja2_pluralize.src: W: spelling-error %description -l en_US py -> pt, p, y
3 packages and 0 specfiles checked; 0 errors, 3 warnings.




Requires
--------
python3-jinja2_pluralize (rpmlib, GLIBC filtered):
    python(abi)

python-jinja2_pluralize (rpmlib, GLIBC filtered):
    python(abi)
    python-inflect
    python3-inflect



Provides
--------
python3-jinja2_pluralize:
    python3-jinja2_pluralize

python-jinja2_pluralize:
    python-jinja2_pluralize



Source checksums
----------------
https://pypi.python.org/packages/source/j/jinja2_pluralize/jinja2_pluralize-0.2.0.tar.gz :
  CHECKSUM(SHA256) this package     : 96649a8f2c5e5c1058b68b68c7a93e572831bbb9774accdcf62449b56bfc28e7
  CHECKSUM(SHA256) upstream package : 96649a8f2c5e5c1058b68b68c7a93e572831bbb9774accdcf62449b56bfc28e7


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1117483
Buildroot used: fedora-20-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Please:
- Update to 0.2.1
- Separate the requires for python3:

%package -n python3-jinja2_pluralize
Summary: Jinja2 pluralize filters
BuildRequires: python3-devel, python3-nose, python3-setuptools
Requires: python3-inflect

Comment 3 Julien Enselme 2014-08-01 16:22:50 UTC
Requires are now correct. Rpmlint is run on all installed packages and reports nothing. Package installs correctly.

Approved!

Comment 4 David Shea 2014-08-01 17:03:14 UTC
New Package SCM Request
=======================
Package Name: pyhton-jinja2_pluralize
Short Description: Jinja2 pluralize filters
Upstream URL: https://pypi.python.org/pypi/jinja2_pluralize/
Owners: dshea
Branches: f20 f21
InitialCC:

Comment 5 Gwyn Ciesla 2014-08-01 17:50:29 UTC
WARNING: Requested package name pyhton-jinja2_pluralize doesn't match bug
summary python-jinja2_pluralize

Comment 6 David Shea 2014-08-01 17:51:52 UTC
Fat fingered it, sorry.

New Package SCM Request
=======================
Package Name: python-jinja2_pluralize
Short Description: Jinja2 pluralize filters
Upstream URL: https://pypi.python.org/pypi/jinja2_pluralize/
Owners: dshea
Branches: f20 f21
InitialCC:

Comment 7 Gwyn Ciesla 2014-08-01 18:32:18 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2014-08-01 19:02:17 UTC
python-jinja2_pluralize-0.2.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-jinja2_pluralize-0.2.1-1.fc20

Comment 9 Fedora Update System 2014-08-03 01:58:23 UTC
python-jinja2_pluralize-0.2.1-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 10 Fedora Update System 2014-08-15 02:34:55 UTC
python-jinja2_pluralize-0.2.1-1.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.