Red Hat Bugzilla – Bug 112528
changing password to one that has ; doesn't work
Last modified: 2007-04-18 13:00:46 EDT
From Bugzilla Helper: User-Agent: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT) Description of problem: I entered a new password that had a semi-colon (;) in the middle, and the app took the password only up to the semi-colon, treating the rest as a "command". I only spotted the error message by chance in the terminal window when quitting. There was no other indication that this was what was happening. I then went to smbpasswd on the command line, and it worked fine with the semi-colon. Version-Release number of selected component (if applicable): redhat-config-samba-1.0.4-1 How reproducible: Always Steps to Reproduce: 1.Preferences -> Samba Users -> Edit User 2.Enter a password with a semi-colon (;) in the middle of it somewhere 3.verify that the password as entered is only up to the semi-colon Actual Results: I could not login with my full password. I noticed an error in the terminal from which I started redhat-config-samba saying that it didn't recognize the command "last_part_of_my_password" Expected Results: It should be capable of accepting passwords with semi-colons in them, as passwd and smbpasswd do. Additional info:
*** Bug 113199 has been marked as a duplicate of this bug. ***
Should be fixed in system-config-samba-1.2.2-1 in Rawhide. Thanks for your report.
> os.system('/usr/bin/smbpasswd -a -s %s "%s"' %(unix_name, password)) This won't work if the password contains for example ";any command Replacing the "%s" by '%s' (+ python quoting) won't help against ';any command using os.exec* should avoid these issues. BUT in any of these cases the password can be seen using (ps). The password should be passed to smbpasswd via a pipe (os.popen*) instead of the command line.
system-config-samba-1.2.12-1 will use os.popen instead of os.system.
*** Bug 120151 has been marked as a duplicate of this bug. ***