RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Via Bug 1004420, we introduced a few "qcow2 corruption prevention" patches.

But there are some recent upstream follow-ups that apparently should be included as well. This BZ is to track it and analyse which of these fixes should be backported.

Right now I see the following two series:



Date: Thu,  7 Aug 2014 22:47:52 +0200
From: Max Reitz <mreitz>
Subject: [Qemu-devel] [PATCH 0/3] qcow2: Prevent corruption-related crashes

Max Reitz (3):
  qcow2: Catch !*host_offset for data allocation
  iotests: Add test for image header overlap
  block: Catch !bs->drv in bdrv_check()

AND

Date: Wed, 13 Aug 2014 23:01:42 +0200
From: Max Reitz <mreitz>
Subject: [Qemu-devel] [PATCH 0/8] qcow2: Fix image repairing

Max Reitz (8):
  qcow2: Factor out refcount accounting for check
  qcow2: Factor out refcount comparison for check
  qcow2: Fix refcount blocks beyond image end
  qcow2: Do not perform potentially damaging repairs
  qcow2: Rebuild refcount structure during check
  qcow2: Clean up after refcount rebuild
  iotests: Fix test outputs
  iotests: Add test for potentially damaging repairs

Fix included in qemu-kvm-0.12.1.2-2.469.el6

Hi, Max

We verified the bug 1004420 before with the test case 060 in the qemu-iotests.  So how do we verify this one? Which test cases or what scenarios we should execute? 

Thanks,
Qunfang

Hi Qunfang,

The backport for this BZ includes additions to some iotests, so using them as a basis should be good. Tests with additional test cases are 060, 107, 108, and 114, so these should pass. On the other hand, running these test cases from qemu-kvm-0.12.1.2-2.469.el6 with qemu-kvm-0.12.1.2-2.468.el6 should fail.

Additionally, all tests which passed before the version the fix for this BZ is included in should still pass for qcow2, i.e., a pretty important thing to make sure is that qcow2 still works as before.

I hope this helps,

Max

Created attachment 1024110 [details]
Reproduction test log

Created attachment 1024111 [details]
Verification test log

Setting to VERIFIED according to comment 9, comment 10, comment 11.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1275.html