Bug 1131735

+++ This bug was initially created as a clone of Bug #1120955 +++

Now, when users edit the properties of virtual machines that are running, those changes are applied when the virtual machine next shuts down. Before, the changes would simply not be applied at all.

This should involve a simple note box outlining the new behavior somewhere near topic 12677 in the Administration Guide.

PRD Bug: https://bugzilla.redhat.com/show_bug.cgi?id=922377

--- Additional comment from Tahlia Richardson on 2014-08-14 03:13:30 EDT ---

Hi Omer,

Can you please confirm whether I've understood this correctly, or if I've missed something?  

To my understanding, all properties can now be edited while the VM is running, and all changes will be applied when the VM is shut down/restarted.

So, the changes that need to be made to the documentation[1] are: 

1. Remove mentions of the VM needing to be powered off in order to edit some settings.

2. Remove the list of fields that can be editing while the VM is running (since it is now all of them). 


[1] https://documentation-devel.engineering.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Virtualization/3.5-Beta/html-single/Administration_Guide/index.html#Editing_Virtual_Machine_Properties1


Thanks,
Tahlia

--- Additional comment from Omer Frenkel on 2014-08-17 08:49:19 EDT ---

1. dont know if i'd remove it, it would make sense to explain vms can be edited while running, but only some of the properties will be applied imeediately, and some would be applied on the next run.

2. maybe we can change the list to describe the fields that apply immediately, does this make sense?

--- Additional comment from Tahlia Richardson on 2014-08-17 19:41:37 EDT ---

1. Ah, I see. I'll do that. Thanks!

2. Yes, that makes sense. Is the list of fields that apply immediately the same as the list already in the doc, or does it need updating?

--- Additional comment from Tahlia Richardson on 2014-08-17 21:29:33 EDT ---

Revised text, pending confirmation of the list of changes that will apply immediately: 

"Summary
Changes to storage, operating system, or networking parameters can adversely affect the virtual machine. Ensure that you have the correct details before attempting to make any changes. Virtual machines can be editing while running, but must be restarted or shut down before some changes will be applied. This procedure explains how to edit a virtual machine. It is necessary to edit a virtual machine in order to change its settings.
⁠
Procedure 9.9. Editing a virtual machine:

   1. Select the virtual machine to be edited.

   2. Click the Edit button to open the Edit Virtual Machine window.

   3. Change the General, System, Initial Run, Console, Host, High Availability, Resource Allocation, Boot Options, and Custom Options fields as required.

    Changes to the following fields will be applied immediately:

		<list> 

    To apply changes to all other settings, the virtual machine must restarted or shut down.

    4. If the Next Restart Configuration pop-up window appears, click OK. 

    5. Click OK to save your changes. Changes from the list in Step 3 will be applied immediately. All other changes will be applied once you restart your virtual machine. 

Result
You have changed the settings of a virtual machine by editing it."

--- Additional comment from Omer Frenkel on 2014-08-18 05:13:04 EDT ---

list of fields that can be applied immediately:
name, description, comment, vm-type (desktop/server), priority, HA, delete-protection, disable strict user checking (allow-console-reconnect), tunnel-migration (editable with rest-api), custom migration downtime, quota, network interfaces

--- Additional comment from Tahlia Richardson on 2014-08-18 20:58:04 EDT ---

Thanks Omer, I'll update the doc now.

--- Additional comment from Tahlia Richardson on 2014-08-18 23:53:07 EDT ---

Updated topic [12677-699896]

Admin guide rev history [34613-699899]

User Guide rev history [34617-699900]