Created attachment 932710 [details] handover_failure Description of problem: bundle deployment handover fails when app runtime name != war name Version-Release number of selected component (if applicable): jon 3.3 er01.1 How reproducible: always Steps to Reproduce: 1. Create a bundle with 'application_war' in it 2. Deploy bundle giving a 'runtime name != application_war name' 3. Actual results: deployment fails on handover Expected results: deployment goes correct, war is visible under managed server with 'application_war name' & corresponding 'runtime name' Additional info: deployment to domain server directly works correctly with edited 'runtime name' screen-shots attached
Created attachment 932711 [details] bundle_app_runtime_name
Created attachment 932712 [details] eap_doamin_runtime_name_example
Thomas, I'm not sure but I wonder if this is confusion similar to what we fixed in Bug 1119781? Looking at the code I'm not sure, there are two cases, domain and standalone. In both StandaloneASComponent and HostControllerComponent the handleDeployment(BundleHandoverRequest) has a redeployer object I'm unsure of. It may be correct or maybe it should be using filename as opposed to runtimename. I have the feeling that it's actually OK as is. If the problem is in domain only (which I think it is given the description, then the problem may be the line: serverGroupDeploymentAddress.add("deployment", runtimeName); I feel like that maybe should be filename. Anyway, thoughts?
(In reply to Jay Shaughnessy from comment #3) > > Thomas, I'm not sure but I wonder if this is confusion similar to what we > fixed in Bug 1119781? > Yes, it is related. > Looking at the code I'm not sure, there are two cases, domain and > standalone. In both StandaloneASComponent and HostControllerComponent the > handleDeployment(BundleHandoverRequest) has a redeployer object I'm unsure > of. It may be correct or maybe it should be using filename as opposed to > runtimename. I have the feeling that it's actually OK as is. > So have I. Maybe QE has a test case for redeployment but this BZ is about deployment of new application as I understand it. > If the problem is in domain only (which I think it is given the description, > then the problem may be the line: > > serverGroupDeploymentAddress.add("deployment", runtimeName); > > I feel like that maybe should be filename. > > Anyway, thoughts? Right. After you fixed Bug 1119781, I pushed this to release/jon3.3.x: ===== commit 4afff8009c59cb1924180d5a237523f1b3d3b63b Author: Thomas Segismont <tsegismo> Date: Thu Jul 24 16:09:23 2014 +0200 Bug 1050014 - Cannot deploy bundle to EAP domain mode Deployment node must be created with the filename, not the runtime name See also Bug 1119781 - runtime name provided for deployment child creation overrides application name and path Cherry-picked from cede4b6 ===== While I think the changes in commit 4afff8009c59cb1924180d5a237523f1b3d3b63b are correct for a standalone server, I believe you're right, I forgot to update the serverGroupDeploymentAddress initialization code in HostControllerComponent.
Fixed in master commit 454bcaed5fe10a6f912c929b227274046d0396e4 Author: Thomas Segismont <tsegismo> Date: Sat Aug 30 12:07:17 2014 +0200 The server group deployment node was created correctly (with name = filename) but then erroneously addressed (with name = runtimename)
Cherry-picked to release/jon3.3.x: commit e35bca4532c7fe1aa36bab18851f62966e7a0b5c Author: Thomas Segismont <tsegismo> Date: Sat Aug 30 12:07:17 2014 +0200 Bug 1135551 - bundle deployment handover fails when app runtime name != war name The server group deployment node was created correctly (with name = filename) but then erroneously addressed (with name = runtimename) (cherry picked from commit 454bcaed5fe10a6f912c929b227274046d0396e4)
Moving to ON_QA as available for test with the following brew build: https://brewweb.devel.redhat.com//buildinfo?buildID=381194
Created attachment 934375 [details] handover_passed
verified in JON 3.3 ER02 screen-shot attached