Bug 1140549
| Summary: | DHT: Rebalance process crash after add-brick and `rebalance start' operation | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Nithya Balachandran <nbalacha> |
| Component: | distribute | Assignee: | Nithya Balachandran <nbalacha> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.5.2 | CC: | bugs, gluster-bugs, ndevos, saujain, sdharane, srangana, ssamanta, surs, vbellur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.3 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1139812 | Environment: | |
| Last Closed: | 2014-11-21 16:02:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1139812, 1151343 | ||
| Bug Blocks: | 1125231, 1139213, 1142654 | ||
|
Description
Nithya Balachandran
2014-09-11 08:35:54 UTC
REVIEW: http://review.gluster.org/8732 (cluster/dht: Fixed double UNWIND in lookup everywhere code) posted (#1) for review on release-3.5 by N Balachandran (nbalacha) REVIEW: http://review.gluster.org/8732 (cluster/dht: Fixed double UNWIND in lookup everywhere code) posted (#2) for review on release-3.5 by N Balachandran (nbalacha) REVIEW: http://review.gluster.org/8732 (cluster/dht: Fixed double UNWIND in lookup everywhere code) posted (#3) for review on release-3.5 by N Balachandran (nbalacha) COMMIT: http://review.gluster.org/8732 committed in release-3.5 by Niels de Vos (ndevos) ------ commit 8c6eb5e04f837f679b3ca04ef784054afb18d66c Author: Shyam <srangana> Date: Thu Sep 11 14:21:23 2014 +0530 cluster/dht: Fixed double UNWIND in lookup everywhere code In dht_lookup_everywhere_done: Line: 1194 we call DHT_STACK_UNWIND and in the same if condition we go ahead and call, goto unwind_hashed_and_cached; which at Line 1371 calls another UNWIND. As is obvious, higher frames could cleanup their locals and on receiving the next unwind could cause a coredump of the process. Fixed the same by calling the required return post the first unwind Change-Id: Ic5d57da98255b8616a65b4caaedabeba9144fd49 BUG: 1140549 Signed-off-by: Shyam <srangana> Reviewed-on: http://review.gluster.org/8666 Reviewed-by: N Balachandran <nbalacha> Reviewed-by: Vijay Bellur <vbellur> Reviewed-by: Jeff Darcy <jdarcy> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: susant palai <spalai> (cherry picked from commit b3314ea6e820fb659255d0e6e9a32ea259b7526d) Signed-off-by: Nithya Balachandran <nbalacha> Reviewed-on: http://review.gluster.org/8732 Reviewed-by: Niels de Vos <ndevos> The first (and last?) Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-October/018990.html [2] http://supercolony.gluster.org/pipermail/gluster-users/ The second Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions have been made available on [2] to make testing easier. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019359.html [2] http://download.gluster.org/pub/gluster/glusterfs/qa-releases/3.5.3beta2/ This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.3, please reopen this bug report. glusterfs-3.5.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/announce/2014-November/000042.html [2] http://supercolony.gluster.org/pipermail/gluster-users/ |