Bug 1140556 - Core: client crash while doing rename operations on the mount
Summary: Core: client crash while doing rename operations on the mount
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: 3.5.2
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Nithya Balachandran
QA Contact:
URL:
Whiteboard:
Depends On: 1139273 1139506
Blocks: glusterfs-3.5.3
TreeView+ depends on / blocked
 
Reported: 2014-09-11 08:55 UTC by Nithya Balachandran
Modified: 2014-11-21 16:14 UTC (History)
8 users (show)

Fixed In Version: glusterfs-3.5.3
Doc Type: Bug Fix
Doc Text:
Clone Of: 1139506
Environment:
Last Closed: 2014-11-21 16:02:46 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Comment 1 Anand Avati 2014-09-15 07:31:55 UTC
REVIEW: http://review.gluster.org/8733 (cluster/dht: fix memory corruption in locking api.) posted (#1) for review on release-3.5 by N Balachandran (nbalacha)

Comment 2 Anand Avati 2014-09-23 08:53:58 UTC
REVIEW: http://review.gluster.org/8733 (cluster/dht: fix memory corruption in locking api.) posted (#2) for review on release-3.5 by N Balachandran (nbalacha)

Comment 3 Anand Avati 2014-09-24 09:01:20 UTC
REVIEW: http://review.gluster.org/8733 (cluster/dht: fix memory corruption in locking api.) posted (#3) for review on release-3.5 by N Balachandran (nbalacha)

Comment 4 Anand Avati 2014-10-01 10:37:44 UTC
COMMIT: http://review.gluster.org/8733 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit 66ebbb55918645928bc479c0e723f035a4c1ec11
Author: Raghavendra G <rgowdapp>
Date:   Thu Sep 11 14:23:44 2014 +0530

    cluster/dht: fix memory corruption in locking api.
    
    <man 3 qsort>
    
         The  contents  of the array are sorted in ascending order
         according to a comparison function pointed to by compar, which is
         called with two arguments that "point to the objects being
         compared".
    
    </man 3 qsort>
    
    qsort passes "pointers to members of the array" to comparision
    function. Since the members of the array happen to be (dht_lock_t *),
    the arguments passed to dht_lock_request_cmp are of type (dht_lock_t
    **). Previously we assumed them to be of type (dht_lock_t *), which
    resulted in memory corruption.
    
    Change-Id: Iee0758704434beaff3c3a1ad48d549cbdc9e1c96
    BUG: 1140556
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/8659
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Reviewed-by: Vijay Bellur <vbellur>
    (cherry picked from commit ed4a754f7b6b103b23b2c3e29b8b749cd9db89f3)
    Signed-off-by: Nithya Balachandran <nbalacha>
    Reviewed-on: http://review.gluster.org/8733
    Reviewed-by: Niels de Vos <ndevos>

Comment 5 Niels de Vos 2014-10-05 13:00:09 UTC
The first (and last?) Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-October/018990.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 6 Niels de Vos 2014-11-05 09:24:47 UTC
The second Beta for GlusterFS 3.5.3 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.3beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions have been made available on [2] to make testing easier.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019359.html
[2] http://download.gluster.org/pub/gluster/glusterfs/qa-releases/3.5.3beta2/

Comment 7 Niels de Vos 2014-11-21 16:02:46 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.3, please reopen this bug report.

glusterfs-3.5.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/announce/2014-November/000042.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.