Bug 1145086 - [SNAPSHOT]: Snapshot of volume with thick provisioned LV as bricks does not give proper error message
Summary: [SNAPSHOT]: Snapshot of volume with thick provisioned LV as bricks does not g...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
urgent
high
Target Milestone: ---
Assignee: Sachin Pandit
QA Contact:
URL:
Whiteboard: SNAPSHOT
Depends On: 1123646
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-22 11:01 UTC by Sachin Pandit
Modified: 2015-07-26 22:05 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.6.0beta2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1123646
Environment:
Last Closed: 2014-11-11 08:39:44 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Sachin Pandit 2014-09-22 11:01:46 UTC
+++ This bug was initially created as a clone of Bug #1123646 +++

Description of problem:

Snapshot is supported only for thinly provisioned LV. Therefore to take snapshot all the bricks of the volume must be on thinly provisioned LV, 

Snapshot command does fail if one or more brick(s) are thick LV, but the error message is not clear. It fails with the following error message:

"snapshot create: failed: Commit failed on localhost. Please check log file for details."


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
Snapshot command fail if one or more brick(s) are thick LV, but the error message is not clear. It fails with the following error message:

"snapshot create: failed: Commit failed on localhost. Please check log file for details."


Expected results:
Snapshot command should fail with accurate error message.

Additional info:

--- Additional comment from Anand Avati on 2014-07-27 10:45:48 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for snapshot create command) posted (#1) for review on master by Rajesh Joseph (rjoseph)

--- Additional comment from Anand Avati on 2014-07-28 02:33:06 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for snapshot create command) posted (#2) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Anand Avati on 2014-07-30 02:17:28 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for snapshot create command) posted (#3) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Anand Avati on 2014-07-30 05:34:53 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for snapshot create command) posted (#4) for review on master by Krishnan Parthasarathi (kparthas)

--- Additional comment from Anand Avati on 2014-07-30 05:35:08 EDT ---

COMMIT: http://review.gluster.org/8377 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 8732ee5319bfe4649473c29458a6ab65b73d5516
Author: Rajesh Joseph <rjoseph>
Date:   Sun Jul 27 10:36:52 2014 -0400

    glusterd/snapshot: Proper err msg for snapshot create command
    
    problem: Snapshot command fails if one or more bricks are not thinly
    provisioned. But the error message is a generic error message which
    is confusing to the user.
    
    fix: Provide correct error message in case of failure.
    
    Change-Id: Iad247f966423a8f73ef6da57cab7ed6cddc05861
    BUG: 1123646
    Signed-off-by: Rajesh Joseph <rjoseph>
    Reviewed-on: http://review.gluster.org/8377
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 1 Anand Avati 2014-09-22 11:34:03 UTC
REVIEW: http://review.gluster.org/8800 (glusterd/snapshot: Proper err msg for snapshot create command) posted (#1) for review on release-3.6 by Sachin Pandit (spandit)

Comment 2 Anand Avati 2014-09-22 11:51:50 UTC
REVIEW: http://review.gluster.org/8800 (glusterd/snapshot: Proper err msg for snapshot create command.) posted (#2) for review on release-3.6 by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-09-23 09:01:28 UTC
COMMIT: http://review.gluster.org/8800 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit c41d745a00e9609041e8d49aa69302af25fdc3ab
Author: Rajesh Joseph <rjoseph>
Date:   Sun Jul 27 10:36:52 2014 -0400

    glusterd/snapshot: Proper err msg for snapshot create command.
    
    problem: Snapshot command fails if one or more bricks are not thinly
    provisioned. But the error message is a generic error message which
    is confusing to the user.
    
    fix: Provide correct error message in case of failure.
    
    Change-Id: Iad247f966423a8f73ef6da57cab7ed6cddc05861
    BUG: 1145086
    Signed-off-by: Rajesh Joseph <rjoseph>
    Reviewed-on: http://review.gluster.org/8377
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8800
    Reviewed-by: Vijaikumar Mallikarjuna <vmallika>
    Tested-by: Gluster Build System <jenkins.com>

Comment 4 Niels de Vos 2014-09-25 08:28:04 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018883.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-11 08:39:44 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.