Bug 1150610 - Review Request: kalibrate-rtl - GSM based frequency calibration for rtl-sdr
Summary: Review Request: kalibrate-rtl - GSM based frequency calibration for rtl-sdr
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Florian "der-flo" Lehner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-08 14:04 UTC by Jaroslav Škarvada
Modified: 2014-11-01 16:24 UTC (History)
2 users (show)

Fixed In Version: kalibrate-rtl-0.4.1-3.20141008gitaae11c8a.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-14 11:44:20 UTC
Type: ---
Embargoed:
dev: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jaroslav Škarvada 2014-10-08 14:04:40 UTC
Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/kalibrate-rtl.spec
SRPM URL: https://fedorapeople.org/~jskarvad/gnuradio/kalibrate-rtl-0.4.1-1.20141008gitaae11c8a.fc20.src.rpm
Description: Kalibrate, or kal, can scan for GSM base stations in a given frequency band and can use those GSM base stations to calculate the local oscillator frequency offset.
Fedora Account System Username: jskarvad

Comment 1 Florian "der-flo" Lehner 2014-10-08 17:41:27 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments

     Yes - it is documented. But why are you generating your own tarball?
     Please take a look at:
     https://fedoraproject.org/wiki/Packaging:SourceURL#Github


[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
   ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7801727
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kalibrate-rtl-0.4.1-1.20141008gitaae11c8a.fc22.x86_64.rpm
          kalibrate-rtl-0.4.1-1.20141008gitaae11c8a.fc22.src.rpm
kalibrate-rtl.x86_64: W: spelling-error Summary(en_US) sdr -> sir, Sadr
kalibrate-rtl.x86_64: W: spelling-error %description -l en_US kal -> kl, kale, cal
kalibrate-rtl.x86_64: W: no-manual-page-for-binary kal-rtl
kalibrate-rtl.src: W: spelling-error Summary(en_US) sdr -> sir, Sadr
kalibrate-rtl.src: W: spelling-error %description -l en_US kal -> kl, kale, cal
kalibrate-rtl.src: W: invalid-url Source0: kalibrate-rtl-0.4.1-20141008gitaae11c8a.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint kalibrate-rtl
kalibrate-rtl.x86_64: W: spelling-error Summary(en_US) sdr -> sir, Sadr
kalibrate-rtl.x86_64: W: spelling-error %description -l en_US kal -> kl, kale, cal
kalibrate-rtl.x86_64: W: no-manual-page-for-binary kal-rtl
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
kalibrate-rtl (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libfftw3.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_4.0.0)(64bit)
    libm.so.6()(64bit)
    librt.so.1()(64bit)
    librtlsdr.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libusb-1.0.so.0()(64bit)
    rtld(GNU_HASH)



Provides
--------
kalibrate-rtl:
    kalibrate-rtl
    kalibrate-rtl(x86-64)



Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1150610
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 2 Jaroslav Škarvada 2014-10-10 12:37:13 UTC
(In reply to Florian "der-flo" Lehner from comment #1)
Thanks for the review.

New version:
Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/kalibrate-rtl.spec
SRPM URL: https://fedorapeople.org/~jskarvad/gnuradio/kalibrate-rtl-0.4.1-2.20141008gitaae11c8a.fc20.src.rpm

Comment 3 Florian "der-flo" Lehner 2014-10-10 16:23:03 UTC
hi!

It looks fine, so I approve it.

Cheers,
 Flo

For the records:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7822770

Comment 4 Jaroslav Škarvada 2014-10-13 08:18:24 UTC
New Package SCM Request
=======================
Package Name: kalibrate-rtl
Short Description: GSM based frequency calibration for rtl-sdr
Upstream URL: http://github.com/steve-m/kalibrate-rtl
Owners: jskarvad
Branches: f20 f21 epel7
InitialCC:

Comment 5 Kevin Fenzi 2014-10-13 23:29:41 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-10-14 11:46:21 UTC
kalibrate-rtl-0.4.1-2.20141008gitaae11c8a.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/kalibrate-rtl-0.4.1-2.20141008gitaae11c8a.fc21

Comment 7 Fedora Update System 2014-10-14 11:47:23 UTC
kalibrate-rtl-0.4.1-2.20141008gitaae11c8a.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/kalibrate-rtl-0.4.1-2.20141008gitaae11c8a.fc20

Comment 8 Fedora Update System 2014-10-14 13:40:39 UTC
kalibrate-rtl-0.4.1-3.20141008gitaae11c8a.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/kalibrate-rtl-0.4.1-3.20141008gitaae11c8a.el7

Comment 9 Fedora Update System 2014-10-27 03:27:03 UTC
kalibrate-rtl-0.4.1-3.20141008gitaae11c8a.fc20 has been pushed to the Fedora 20 stable repository.

Comment 10 Fedora Update System 2014-10-31 01:23:46 UTC
kalibrate-rtl-0.4.1-3.20141008gitaae11c8a.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 11 Fedora Update System 2014-11-01 16:24:50 UTC
kalibrate-rtl-0.4.1-3.20141008gitaae11c8a.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.