Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/libosmo-dsp.spec SRPM URL: https://fedorapeople.org/~jskarvad/gnuradio/libosmo-dsp-0.3-1.fc20.src.rpm Description: A library with SDR DSP primitives. Fedora Account System Username: jskarvad
formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 770c072c8111836a305a356dda24ff9e75c77e7c libosmo-dsp-0.3.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK* compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. Ok correct scriptlets present. OK code, not content. OK documentation is in -docs subpackage OK %docs are not necessary for the proper functioning of the package. OK headers in -devel subpackage OK pkgconfig files in -devel subpackage OK no libtool .la droppings. OK not a GUI app. - please run make with V=1 to see compiler command line in logs - rpmlint is harmless libosmo-dsp-devel.x86_64: W: only-non-binary-in-usr-lib libosmo-dsp-devel.x86_64: W: no-documentation the docs are in own subpackage The package is APPROVED.
(In reply to Dan Horák from comment #1) Thanks for the review. > - please run make with V=1 to see compiler command line in logs > Will do. > The package is APPROVED. > According this comment, changig fedora-cvs to ? and fedora-review to +.
New Package SCM Request ======================= Package Name: libosmo-dsp Short Description: libosmo-dsp - A library with SDR DSP primitives Upstream URL: http://cgit.osmocom.org/libosmo-dsp/ Owners: jskarvad Branches: f20 f21 epel7 InitialCC:
Git done (by process-git-requests).
libosmo-dsp-0.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/libosmo-dsp-0.3-1.el7
libosmo-dsp-0.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/libosmo-dsp-0.3-1.fc21
libosmo-dsp-0.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libosmo-dsp-0.3-1.fc20
libosmo-dsp-0.3-1.fc20 has been pushed to the Fedora 20 stable repository.
libosmo-dsp-0.3-1.fc21 has been pushed to the Fedora 21 stable repository.
libosmo-dsp-0.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository.