Bug 1155017 - Tracker bug for afrv1 changelog support in afrv2
Summary: Tracker bug for afrv1 changelog support in afrv2
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pranith Kumar K
QA Contact:
URL:
Whiteboard:
Depends On: 1128721 1136829
Blocks: glusterfs-3.6.0
TreeView+ depends on / blocked
 
Reported: 2014-10-21 09:28 UTC by Pranith Kumar K
Modified: 2014-11-10 15:14 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1136829
Environment:
Last Closed: 2014-11-10 15:14:18 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Pranith Kumar K 2014-10-21 09:28:50 UTC
+++ This bug was initially created as a clone of Bug #1136829 +++

+++ This bug was initially created as a clone of Bug #1128721 +++

Description of problem:
This bug tracks the changes need to be done for afrv1 changelog support in afrv2

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-08-11 08:19:08 EDT ---

REVIEW: http://review.gluster.org/8456 (cluster/afr: s/healed_sinks/sinks in data self-heal) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-12 00:02:47 EDT ---

REVIEW: http://review.gluster.org/8456 (cluster/afr: Fix all locked_on bricks are sinks check is self-heals) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-12 00:03:33 EDT ---

REVIEW: http://review.gluster.org/8456 (cluster/afr: Fix all locked_on bricks are sinks check in self-heals) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-12 02:41:55 EDT ---

REVIEW: http://review.gluster.org/8456 (cluster/afr: Fix all locked_on bricks are sinks check in self-heals) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-25 09:11:47 EDT ---

REVIEW: http://review.gluster.org/8456 (cluster/afr: Fix all locked_on bricks are sinks check in self-heals) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-25 09:12:05 EDT ---

REVIEW: http://review.gluster.org/8536 (cluster/afr: Add afr-v1 xattr compatibility) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-25 09:12:08 EDT ---

REVIEW: http://review.gluster.org/8537 (cluster/afr: Fix synchronization issue with entry, name self-heals) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-25 09:12:11 EDT ---

REVIEW: http://review.gluster.org/8538 (tests: Data self-heal test cases) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-25 09:12:32 EDT ---

REVIEW: http://review.gluster.org/8539 (tests: entry self-heal test cases) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-26 01:52:59 EDT ---

REVIEW: http://review.gluster.org/8456 (cluster/afr: Fix all locked_on bricks are sinks check in self-heals) posted (#6) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-26 04:17:28 EDT ---

COMMIT: http://review.gluster.org/8456 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit dc450ab5e3798b47e89e90b64c49cb8e1f20efce
Author: Pranith Kumar K <pkarampu>
Date:   Fri Aug 8 11:52:17 2014 +0530

    cluster/afr: Fix all locked_on bricks are sinks check in self-heals
    
    Problem:
    Counts may give wrong results when the number of bricks is > 2. If the
    locks are acquired on one source and sink, but the source accuses even the
    down sink then there will be 2 sinks and lock is acquired on 2 bricks so
    even when there is a clear source and sink **_finalize_source functions think
    the file/directory is in split-brain.
    
    Fix:
    Check that all the bricks which are locked are sinks.
    
    Change-Id: Ia43790e8e1bfb5e72a3d0b56bcad94abd0dc58ab
    BUG: 1128721
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8456
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Gluster Build System <jenkins.com>

--- Additional comment from Anand Avati on 2014-08-26 08:26:01 EDT ---

REVIEW: http://review.gluster.org/8537 (cluster/afr: Fix synchronization issue with entry, name self-heals) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-26 08:26:04 EDT ---

REVIEW: http://review.gluster.org/8536 (cluster/afr: Add afr-v1 xattr compatibility) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-26 08:26:07 EDT ---

REVIEW: http://review.gluster.org/8539 (tests: entry self-heal test cases) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-26 08:26:10 EDT ---

REVIEW: http://review.gluster.org/8538 (tests: Data self-heal test cases) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-09-03 08:03:37 EDT ---

REVIEW: http://review.gluster.org/8593 (cluster/afr: Fix all locked_on bricks are sinks check in self-heals) posted (#1) for review on release-3.6 by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-09-12 05:55:41 EDT ---

COMMIT: http://review.gluster.org/8593 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit 43d49fab8cce7d06fc63f23757abc7f2c70a6d48
Author: Pranith Kumar K <pkarampu>
Date:   Fri Aug 8 11:52:17 2014 +0530

    cluster/afr: Fix all locked_on bricks are sinks check in self-heals
    
            Backport of http://review.gluster.org/8456
    
    Problem:
    Counts may give wrong results when the number of bricks is > 2. If the
    locks are acquired on one source and sink, but the source accuses even the
    down sink then there will be 2 sinks and lock is acquired on 2 bricks so
    even when there is a clear source and sink **_finalize_source functions think
    the file/directory is in split-brain.
    
    Fix:
    Check that all the bricks which are locked are sinks.
    
    BUG: 1136829
    Change-Id: I56a8f9ff261bdeec8c441237c485036141b6f00d
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8593
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Vijay Bellur <vbellur>

--- Additional comment from Niels de Vos on 2014-09-22 08:45:29 EDT ---

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

--- Additional comment from Anand Avati on 2014-09-23 10:48:25 EDT ---

REVIEW: http://review.gluster.org/8823 (cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh) posted (#1) for review on release-3.6 by Krutika Dhananjay (kdhananj)

--- Additional comment from Anand Avati on 2014-09-23 12:50:26 EDT ---

COMMIT: http://review.gluster.org/8823 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit 6fffc4eaf408cb9b0b2891404ee54f4ab1dd5e2e
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Sep 18 18:26:08 2014 +0530

    cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh
    
            Backport of: http://review.gluster.org/8816
    
    Change-Id: I8463a579f542a2336b02edba8f5fbfea0edbbffe
    BUG: 1136829
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/8823
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

--- Additional comment from Anand Avati on 2014-09-25 03:08:00 EDT ---

REVIEW: http://review.gluster.org/8845 (cluster/afr: Fix locking issues in entry self-heal) posted (#1) for review on release-3.6 by Krutika Dhananjay (kdhananj)

--- Additional comment from Niels de Vos on 2014-09-25 04:27:40 EDT ---

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta2 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018883.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

--- Additional comment from Anand Avati on 2014-09-26 07:05:09 EDT ---

COMMIT: http://review.gluster.org/8845 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit 537ad5b9ea1e95cf68c2ced2e56e10283f221e11
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Sep 23 17:03:53 2014 +0530

    cluster/afr: Fix locking issues in entry self-heal
    
            Backport of: http://review.gluster.org/#/c/8837/
    
    Original reporter of the bug & designer of the solution:
            Pranith Kumar K <pkarampu>
    
    Change-Id: I6e36326e1d9398ede82166b358ab438367dd3011
    BUG: 1136829
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/8845
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2014-10-21 09:38:06 UTC
REVIEW: http://review.gluster.org/8956 (cluster/afr: Add afr-v1 xattr compatibility) posted (#1) for review on release-3.6 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-10-22 10:04:00 UTC
COMMIT: http://review.gluster.org/8956 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit d7e56dde3c19a11647eae9cf6a868c191c641489
Author: Pranith Kumar K <pkarampu>
Date:   Wed Aug 20 21:50:06 2014 +0530

    cluster/afr: Add afr-v1 xattr compatibility
    
            Backport of http://review.gluster.org/8536
    
    All the special cases v1 handles and also
    self-accusing pending changelog from v1 pre-op also is handled
    in this patch.
    
    BUG: 1155017
    Change-Id: I86cf6b80492be5c1f240c74f91a0e1b0dd9b58b2
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8956
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-11-10 15:14:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.