Bug 1155292 - VDSM fails to configure libvirtd module on upgrade 3.4 --> 3.5
Summary: VDSM fails to configure libvirtd module on upgrade 3.4 --> 3.5
Keywords:
Status: CLOSED DUPLICATE of bug 1157185
Alias: None
Product: oVirt
Classification: Retired
Component: vdsm
Version: 3.5
Hardware: x86_64
OS: Linux
urgent
urgent
Target Milestone: ---
: 3.5.1
Assignee: Yaniv Bronhaim
QA Contact: Yaniv Bronhaim
URL:
Whiteboard: infra
Depends On:
Blocks: oVirt_3.5.1_tracker
TreeView+ depends on / blocked
 
Reported: 2014-10-21 20:12 UTC by Reid Nabinger
Modified: 2016-02-10 19:30 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-27 12:00:23 UTC
oVirt Team: Infra
Embargoed:


Attachments (Terms of Use)

Description Reid Nabinger 2014-10-21 20:12:59 UTC
Description of problem:

During yum update from 3.4 to 3.5, VDSM updates but fails to configure for libvirtd module, and subsequently cycle properly.

Version-Release number of selected component (if applicable):

---> Package vdsm.x86_64 0:4.14.17-0.el6 will be updated
---> Package vdsm.x86_64 0:4.16.7-1.gitdb83943.el6 will be an update


How reproducible:

8/8 of my hosts exhibited in dev.  very.

Steps to Reproduce:
1.  Begin with 3.4 + vdsm 4.14.17 on CentOS 6.5
2.  Add ovirt3.5 repositories and yum update

Actual results:

  Updating   : vdsm-4.16.7-1.gitdb83943.el6.x86_64                                                                                                                             13/30
warning: /etc/vdsm/vdsm.conf created as /etc/vdsm/vdsm.conf.rpmnew
Traceback (most recent call last):
  File "/usr/bin/vdsm-tool", line 224, in <module>
    sys.exit(main())
  File "/usr/bin/vdsm-tool", line 210, in main
    except vdsm.tool.UsageError as e:
AttributeError: 'module' object has no attribute 'UsageError'
Traceback (most recent call last):
  File "/usr/bin/vdsm-tool", line 224, in <module>
    sys.exit(main())
  File "/usr/bin/vdsm-tool", line 210, in main
    except vdsm.tool.UsageError as e:
AttributeError: 'module' object has no attribute 'UsageError'

Expected results:

VDSM should update and cycle without error

Additional info:

Normal behavior returned by simply doing the following -- 

service vdsmd stop
service supervdsmd stop
initctl stop libvirtd
vdsm-tool configure
service supervdsmd start
service vdsmd start

relevant /var/log/messages:

Oct 21 14:52:40 h0lppn014 python: module upgrade_300_networks could not load to vdsm-tool: Traceback (most recent call last):#012  File "/usr/bin/vdsm-tool", line 81, in load_modules#012    mod_absp, mod_desc)#012  File "/usr/lib64/python2.6/site-packages/vdsm/tool/upgrade_300_networks.py", line 30, in <module>#012    from netconf import ifcfg#012ImportError: No module named netconf
Oct 21 14:52:40 h0lppn014 python: module upgrade_300_networks could not load to vdsm-tool: Traceback (most recent call last):#012  File "/usr/bin/vdsm-tool", line 81, in load_modules#012    mod_absp, mod_desc)#012  File "/usr/lib64/python2.6/site-packages/vdsm/tool/upgrade_300_networks.py", line 30, in <module>#012    from netconf import ifcfg#012ImportError: No module named netconf
Oct 21 14:52:40 h0lppn014 python: module upgrade_300_networks could not load to vdsm-tool: Traceback (most recent call last):#012  File "/usr/bin/vdsm-tool", line 81, in load_modules#012    mod_absp, mod_desc)#012  File "/usr/lib64/python2.6/site-packages/vdsm/tool/upgrade_300_networks.py", line 30, in <module>#012    from netconf import ifcfg#012ImportError: No module named netconf

Comment 1 Nir Soffer 2014-10-21 20:17:31 UTC
Can you upload complete /var/log/messages, or at least more of it so we can have info from just before the upgrade until the end of the upgrade?

Comment 2 Reid Nabinger 2014-10-21 20:32:52 UTC
sure thing-- performing upgrade on another host right now, will pastebin this host (same error)

Comment 3 Reid Nabinger 2014-10-21 20:37:44 UTC
This first paste is flooded with I/O errors from about a 5-second period:

http://paste.fedoraproject.org/143978/14139236


This paste I have pulled out the I/O errors so that you could get a larger picture

http://paste.fedoraproject.org/143980/14139237


Thanks!

Comment 4 Yaniv Bronhaim 2014-10-22 10:49:41 UTC
do you have any problem afterwards except those prints? I reproduced it, but its just a backtrace print that we don't need to have in that location .

afaiu, it doesn't block anything and i suggest to fix it for 3.6. it requires to remove all vdsm-tool calls from %post . which might take bit of work and its risky for stable branch.

Comment 5 Reid Nabinger 2014-10-22 15:38:34 UTC
It prints the backtrace, but also doesn't configure VDSM properly.  It is required to run a 'vdsm-tool configure [--module libvirt]'

Once you re-configure vdsm everything works fine.

Comment 6 Yaniv Bronhaim 2014-10-23 11:10:26 UTC
ok. thanks for the info, i missed that.
raising the urgency, the fix will be either taking [1] , or moving the set booleans to be part of the configure call which runs by the user\host-deploy after installation.

This AttributeError is raised only now because of last selinux change which raise an error if sebool set is called when selinux disabled. In that case we get to the except part in vdsm-tool, which checks for UsageError in the new installation code(3.5), but does not exist in previous one which still loaded while importing vdsm.tool during the upgrade. a mess.. we just need to avoid using vdsm-tool calls during %post install (only on postun we can be ensure that we use the updated code and its valid to use vdsm's code)

[1] http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in,cm

Comment 7 Yaniv Bronhaim 2014-10-27 12:00:23 UTC

*** This bug has been marked as a duplicate of bug 1157185 ***


Note You need to log in before you can comment on or make changes to this bug.