Bug 1156250 - DeviceFactoryError: _removeDevice() got an unexpected keyword argument 'moddisk'
Summary: DeviceFactoryError: _removeDevice() got an unexpected keyword argument 'moddisk'
Keywords:
Status: CLOSED DUPLICATE of bug 1154050
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 21
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-24 02:06 UTC by Shawn Starr
Modified: 2014-10-24 02:23 UTC (History)
5 users (show)

Fixed In Version: python-blivet-0.61.6-1.fc21
Clone Of:
Environment:
Last Closed: 2014-10-24 02:23:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Anaconda Stack dump (843.81 KB, text/plain)
2014-10-24 02:07 UTC, Shawn Starr
no flags Details
Anaconda Storage Log (487.32 KB, text/plain)
2014-10-24 02:07 UTC, Shawn Starr
no flags Details
Anaconda Program Log (22.57 KB, text/plain)
2014-10-24 02:08 UTC, Shawn Starr
no flags Details

Description Shawn Starr 2014-10-24 02:06:59 UTC
Description of problem:
When using automatic partitioning, trying to modify change partition sizes fails. It also seems to happen when doing custom partitioning when modifying sizes of a partition designed in UI, fails.

I have an Existing Windows 7 partition on the laptop, with a 100MB reserved partition required by Windows.

Version-Release number of selected component (if applicable):
anaconda 21.48.10-1

How reproducible:
I managed to get it to work once, but aborted to get bug logged.I can reproduce this every time pretty much.

Steps to Reproduce:
1. Unsure if you need Windows partitions created or not 
2. Either wipe existing Linux partition or have none prior 
3. Choose Automatic partition, then try to resize (shrink) the size chosen, fails on some partitions such as /home

Actual results:
Error from Anaconda but no exception or if you attempt to proceed anyway, Anaconda fails and throws full exception dump.

Expected results:
Able to change the automatic partition parameters in UI manually.

Additional info:

I've attached the logs

Comment 1 Shawn Starr 2014-10-24 02:07:21 UTC
Created attachment 950154 [details]
Anaconda Stack dump

Comment 2 Shawn Starr 2014-10-24 02:07:43 UTC
Created attachment 950155 [details]
Anaconda Storage Log

Comment 3 Shawn Starr 2014-10-24 02:08:22 UTC
Created attachment 950156 [details]
Anaconda Program Log

Comment 4 Shawn Starr 2014-10-24 02:14:52 UTC
To clarify:

When you click button to create automatic partitions, then attempt to change partition sizes, it throws error on bottom bar of Anaconda, if you then attempt to save any changes. Anaconda then crashes with a full stack dump.

Comment 5 Adam Williamson 2014-10-24 02:19:48 UTC
I suspect this was fixed by:

commit c1330e58c2ef845894667114d44285591f41d28e
Author: mulhern <amulhern>
Date:   Mon Sep 22 15:04:16 2014 -0400

    Change variable keyword (#1154050)
    
    Related: fed#1154050
    
    Should have gone in with commit
    e54cb958f5e4a8ac756509b072032c38e067f9e7.
    
    Signed-off-by: mulhern <amulhern>

[adamw@adam blivet (f21-branch %)]$ git diff 1ef00bd1f18e6c46784a51e02285e710e35727e5 blivet/partitioning.py
diff --git a/blivet/partitioning.py b/blivet/partitioning.py
index 8779588..c429514 100644
--- a/blivet/partitioning.py
+++ b/blivet/partitioning.py
@@ -861,7 +861,7 @@ def doPartitioning(storage):
     for partition in storage.partitions:
         if not partition.exists and partition.isExtended and \
            not storage.devicetree.findActions(device=partition, action_type="create"):
-            storage.devicetree._removeDevice(partition, moddisk=False, force=True)
+            storage.devicetree._removeDevice(partition, modparent=False, force=True)
 
     partitions = storage.partitions[:]
     for part in storage.partitions:

Comment 6 Adam Williamson 2014-10-24 02:21:15 UTC
That change is in python-blivet-0.61.7-1.fc21 , so if I'm right, this should be fixed in RC1.

Comment 7 Adam Williamson 2014-10-24 02:23:00 UTC

*** This bug has been marked as a duplicate of bug 1154050 ***


Note You need to log in before you can comment on or make changes to this bug.