Spec URL: http://vps533.directvps.nl/python-tzlocal.spec SRPM URL: http://vps533.directvps.nl/python-tzlocal-1.1.2-1.fc20.src.rpm Description: This Python module returns a tzinfo object with the local timezone information under Unix and Win-32. Fedora Account System Username: piotrp koji builds: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=7939755 f22: http://koji.fedoraproject.org/koji/taskinfo?taskID=7939757 f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=7939766 f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=7939770 I will need this package for the next release of graphite-api. I need a sponsor. See my other review-request: https://bugzilla.redhat.com/show_bug.cgi?id=1154213 https://bugzilla.redhat.com/show_bug.cgi?id=1154218 https://bugzilla.redhat.com/show_bug.cgi?id=1154743 (unofficial) package reviews: https://bugzilla.redhat.com/show_bug.cgi?id=1147351 https://bugzilla.redhat.com/show_bug.cgi?id=1151759 https://bugzilla.redhat.com/show_bug.cgi?id=1150734 Thanks!
1) rpmlint on all generated rpms gave following common messages W: summary-not-capitalized C tzinfo object for the local timezone E: description-line-too-long C This Python module returns a tzinfo object with the local timezone information under Unix and Win-32. => you may want to add some word or re-word the summary also limit the line to 80 characters in description 2) I see some removals are done in %install section. Can you add comments to explain why you need to execute rm commands there? 3) you should in %prep rm -rf *.egg-info
Thank you for commenting. I have added the rm commands in %install so that unit tests are not installed. I could not find a policy which mandates this but thought that it would be clean to not install those files as users will not use them. I got the idea from the python-setuptools.spec . If you think they need to be installed I will delete the rm lines. I've added comments to the spec to explain this. I have updated the spec and srpm: - deleted group tag - added license to python3 module - rewritten summary - wrapped description - added rm -rf *.egg-info to %prep - added comments to the rm commands in %install section
I can't see any updated package. Please be habitual with bumping release number. Generating new package and posting links of new SPEC and SRPM. We generally review SRPM which includes SPEC and not just SPEC.
Don't forget to add changes information in a new Changelog entry.
bumped release number: Spec URL: http://vps533.directvps.nl/python-tzlocal.spec SRPM URL: http://vps533.directvps.nl/python-tzlocal-1.1.2-2.fc20.src.rpm
This looks good now :) Review: + is OK - is Needs Work + Package built successful in mock (f22 x86_64) - rpmlint on generated rpms gave output python-tzlocal.src: W: spelling-error Summary(en_US) tzinfo -> tinfoil python-tzlocal.src: W: spelling-error %description -l en_US tzinfo -> tinfoil python3-tzlocal.noarch: W: spelling-error Summary(en_US) tzinfo -> tinfoil python3-tzlocal.noarch: W: summary-not-capitalized C tzinfo object for the local timezone python3-tzlocal.noarch: W: spelling-error %description -l en_US tzinfo -> tinfoil python-tzlocal.noarch: W: spelling-error Summary(en_US) tzinfo -> tinfoil python-tzlocal.noarch: W: spelling-error %description -l en_US tzinfo -> tinfoil 3 packages and 0 specfiles checked; 0 errors, 7 warnings. + Source verified with upstream as sha256sum srpm tarball: 4d9ddb8d5eab086e3a7c504c6e994ffa85df43e40da4d6be776218be051c677a upstream tarball: 4d9ddb8d5eab086e3a7c504c6e994ffa85df43e40da4d6be776218be051c677a + License is CCO and included in LICENSE.txt file + follow python packaging guidelines + rest also looks as per packaging guidelines. Suggestion: 1) Summary for main package python-tzlocal should be "A Python module that tries to figure out what your local timezone is". This is a nice summary as can be seen on github page 2) %description should contain some more information like This Python module returns a tzinfo object with the local timezone information. It requires pytz, and returns pytz tzinfo objects. This module attempts to fix a glaring hole in pytz, that there is no way to get the local timezone information, unless you know the zoneinfo name. 3) use above for python3-tzlocal %description Fix above and for this if you want you don't need to bump release number and package will be ready to be approved.
Please provide updated SPEC and SRPM links here so I can approve this package.
Updated SPEC + SRPM with new summary/description as suggested: Spec URL: http://vps533.directvps.nl/python-tzlocal.spec SRPM URL: http://vps533.directvps.nl/python-tzlocal-1.1.2-2.fc20.src.rpm
APPROVED this package.
and yes have the same summary for python-tzlocal and python3-tzlocal otherwise rpmlint will complain warning :-)
missed that one.. fixed, thanks.
New Package SCM Request ======================= Package Name: python-tzlocal Short Description: A Python module that tries to figure out what your local timezone is Upstream URL: https://github.com/regebro/tzlocal Owners: piotrp Branches: f19 f20 f21 InitialCC: piotrp
Git done (by process-git-requests).
python-tzlocal-1.1.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-2.fc21
python-tzlocal-1.1.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-2.fc20
python-tzlocal-1.1.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-2.fc19
python-tzlocal-1.1.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-3.fc20
python-tzlocal-1.1.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-3.fc21
python-tzlocal-1.1.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-3.fc19
python-tzlocal-1.1.2-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
python-tzlocal-1.1.2-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
python-tzlocal-1.1.2-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: python-tzlocal New Branches: el6 epel7 Owners: piotrp
python-tzlocal-1.1.2-4.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-4.el7
python-tzlocal-1.1.2-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tzlocal-1.1.2-4.el6
python-tzlocal-1.1.2-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
python-tzlocal-1.1.2-4.el6 has been pushed to the Fedora EPEL 6 stable repository.