RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1162966 - xfs should also give a warning out to let customer know the limitation
Summary: xfs should also give a warning out to let customer know the limitation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libguestfs
Version: 7.1
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-12 05:15 UTC by yuliu
Modified: 2015-03-23 01:01 UTC (History)
3 users (show)

Fixed In Version: libguestfs-1.28.1-1.10.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 13:47:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:0303 0 normal SHIPPED_LIVE libguestfs bug fix and enhancement update 2015-03-05 17:34:44 UTC

Description yuliu 2014-11-12 05:15:08 UTC
Description of problem:
For the mke2journal-L, xfs label is limited to 12 bytes. So if you set label longer than that length, it will be truncated. Thus the label set may not be as what you expect. So it is better to add some warning in the help of mke2journal-L to let people know this limitation. This had been fixed on ext2/3/4, bug597118. It should also fix on xfs.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
[root@rhel7libguestfs tests]# guestfish -N fs:xfs
><fs> list-filesystems
/dev/sda1: xfs
><fs> set-e2label /dev/sda1 12345678901234567890
><fs> get-e2label /dev/sda1
123456789012
><fs>

Actual results:


Expected results:
At least a warning should be given in the help or return a warning to make customer know the limitation.

Additional info:

Comment 2 yuliu 2014-11-12 05:25:50 UTC
Addition:
mke2journal-L works fine, but the set-e2label don't.

Comment 3 Pino Toscano 2014-11-12 09:04:59 UTC
The fix for bug 597118 is more than a mere warning, but an hard error.

I will do the same for xfs too, although would be nicer if we wouldn't need to hardcode such values (for ext, swap, and now xfs label lengths).

Anyway, patch posted:
  https://www.redhat.com/archives/libguestfs/2014-November/msg00081.html

Comment 6 yuliu 2014-11-18 06:27:58 UTC
><fs> set-e2label /dev/sda1 12345678901234567890
libguestfs: error: set_e2label: 12345678901234567890: xfs labels are limited to 12 bytes

Verified as above.

Comment 8 errata-xmlrpc 2015-03-05 13:47:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0303.html


Note You need to log in before you can comment on or make changes to this bug.