Description of problem: For the mke2journal-L, xfs label is limited to 12 bytes. So if you set label longer than that length, it will be truncated. Thus the label set may not be as what you expect. So it is better to add some warning in the help of mke2journal-L to let people know this limitation. This had been fixed on ext2/3/4, bug597118. It should also fix on xfs. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: [root@rhel7libguestfs tests]# guestfish -N fs:xfs ><fs> list-filesystems /dev/sda1: xfs ><fs> set-e2label /dev/sda1 12345678901234567890 ><fs> get-e2label /dev/sda1 123456789012 ><fs> Actual results: Expected results: At least a warning should be given in the help or return a warning to make customer know the limitation. Additional info:
Addition: mke2journal-L works fine, but the set-e2label don't.
The fix for bug 597118 is more than a mere warning, but an hard error. I will do the same for xfs too, although would be nicer if we wouldn't need to hardcode such values (for ext, swap, and now xfs label lengths). Anyway, patch posted: https://www.redhat.com/archives/libguestfs/2014-November/msg00081.html
Upstream fix: https://github.com/libguestfs/libguestfs/commit/57547dcdcfb27bdd988d8a561dc2178ea1d23517
><fs> set-e2label /dev/sda1 12345678901234567890 libguestfs: error: set_e2label: 12345678901234567890: xfs labels are limited to 12 bytes Verified as above.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0303.html