Bug 1164333 - Review Request: python-invoke - A Python task execution tool and library
Summary: Review Request: python-invoke - A Python task execution tool and library
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Julien Enselme
QA Contact: Fedora Extras Quality Assurance
Depends On: 1169464 1169469
TreeView+ depends on / blocked
Reported: 2014-11-14 17:06 UTC by Othman Madjoudj
Modified: 2015-01-26 02:36 UTC (History)
2 users (show)

Fixed In Version: python-invoke-0.9.0-4.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2015-01-26 02:36:24 UTC
Type: ---
jujens: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Othman Madjoudj 2014-11-14 17:06:53 UTC
Spec URL: https://athmane.fedorapeople.org/pkgs/python-invoke.spec
SRPM URL: https://athmane.fedorapeople.org/pkgs/python-invoke-0.9.0-1.fc20.src.rpm

Invoke is a Python (2.6+ and 3.2+) task execution tool and library,
drawing inspiration from various sources to arrive at a powerful
and clean feature set.

Fedora Account System Username: athmane

Comment 1 Julien Enselme 2014-11-27 18:08:23 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[X]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[X]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "MIT/X11 (BSD like)", "*No copyright* MIT/X11 (BSD like)", "Unknown or
     generated". 91 files have unknown license. Detailed output of
     licensecheck in /var/tmp/1164333-python-invoke/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[!]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 4 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[X]: Python eggs must not download any dependencies during the build process.
[X]: A package which is used by another package via an egg interface should
     provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: python-invoke-0.9.0-1.fc20.noarch.rpm
python-invoke.noarch: W: no-manual-page-for-binary inv
python-invoke.noarch: W: no-manual-page-for-binary invoke
python3-invoke.noarch: W: no-manual-page-for-binary invoke3
python3-invoke.noarch: W: no-manual-page-for-binary inv3
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages)
# rpmlint python3-invoke python-invoke
python3-invoke.noarch: W: no-manual-page-for-binary invoke3
python3-invoke.noarch: W: no-manual-page-for-binary inv3
python-invoke.noarch: W: no-manual-page-for-binary inv
python-invoke.noarch: W: no-manual-page-for-binary invoke
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
# echo 'rpmlint-done:'

python3-invoke (rpmlib, GLIBC filtered):

python-invoke (rpmlib, GLIBC filtered):



Source checksums
https://pypi.python.org/packages/source/i/invoke/invoke-0.9.0.tar.gz :
  CHECKSUM(SHA256) this package     : f97c3b9e6d8f12327f5f0f39af0544b6b68863a182484b16666243667d767a2b
  CHECKSUM(SHA256) upstream package : f97c3b9e6d8f12327f5f0f39af0544b6b68863a182484b16666243667d767a2b

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1164333
Buildroot used: fedora-20-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

- Please move the dependancy for ptyhon3 in the %package -n python3-invoke section.
- Please add -O1 and --skip-build arguments to setup.py install for python2 and python3.
- Your %files section is incorrect: According to https://fedoraproject.org/wiki/Packaging:Python#Files_to_include you can use:
%{python2_sitelib}/foo/ (I forget the last / sorry)


%dir %{python2_sitelib}/foo (to add the directory)

- If all the build use python3, maybe you can remove the with_python3 flag to ease the reading of the spec file.
- Please remove the invoke.egg-info folder in the %setup section
- This package includes bundled libraries (in the vendor subfolder). Please remove them add them as dependancies and package the tow missing one:
  - six: in the repo as python-six
  - Pexpect: in the repo
  - lexicon (not packaged yet): https://pypi.python.org/pypi/lexicon
  - fluidity (not packaged yet): https://pypi.python.org/pypi/fluidity-sm/0.2.1

Comment 2 Othman Madjoudj 2014-11-29 12:34:06 UTC
Thanks for your input, please find the updated package (aligning with python guidelines), note that it's not usable yet as I need to package the other dependencies.

Note that I'm mainly packaging pyinvoke because it'll be required by the next version of Fabric.

SPEC: https://athmane.fedorapeople.org/pkgs/python-invoke.spec
SRPM: https://athmane.fedorapeople.org/pkgs/python-invoke-0.9.0-2.fc20.src.rpm

* Sat Nov 29 2014 Athmane Madjoudj <athmane>  0.9.0-2
- Remove unbundled libs.
- Remove .egg-info dir 
- Restrict files section
- Add some build options

Comment 3 Julien Enselme 2014-11-29 20:30:54 UTC
> Restrict files section
You must append a / at the end of %{python_sitelib}/invoke and %{python_sitelib}/invoke-%{version}-*.egg-info (and for python3). See the link I posted above.

> Add some build options
The -O1 option is still missing.

> Remove unbundled libs.
I think you forgot to add python-pexpect and python3-pexpect as dependancies.

Good luck with the dependancies. They look like small packages, I think they won't be hard to package.

Comment 4 Othman Madjoudj 2014-12-01 17:13:19 UTC
Please find updated package:

SPEC: https://athmane.fedorapeople.org/pkgs/python-invoke.spec
SRPM: https://athmane.fedorapeople.org/pkgs/python-invoke-0.9.0-3.fc20.src.rpm


* Mon Dec 01 2014 Athmane Madjoudj <athmane>  0.9.0-3
- Update BR
- Minor fixes in files and install sections.

Comment 5 Othman Madjoudj 2014-12-01 18:32:02 UTC
(In reply to Julien Enselme from comment #3)
> Good luck with the dependancies. They look like small packages, I think they
> won't be hard to package.

The dependencies have been submitted for review.

Thank you again for catching those, I did not have the reflex to check bundled lib, it quite rare to have bundled lib on python since pip perfectly supports dependencies.

Comment 6 Julien Enselme 2015-01-11 13:20:48 UTC
Add the missing dependancies to the spec and you're good.

Comment 8 Julien Enselme 2015-01-11 16:52:14 UTC

Comment 9 Othman Madjoudj 2015-01-11 17:46:31 UTC
New Package SCM Request
Package Name: python-invoke
Short Description: A Python task execution tool and library
Upstream URL: http://pyinvoke.org
Owners: athmane
Branches: f20 f21 el6 epel7

Comment 10 Gwyn Ciesla 2015-01-11 21:15:08 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2015-01-12 17:31:44 UTC
python-invoke-0.9.0-4.fc21 has been submitted as an update for Fedora 21.

Comment 12 Fedora Update System 2015-01-14 07:32:52 UTC
python-invoke-0.9.0-4.fc21 has been pushed to the Fedora 21 testing repository.

Comment 13 Fedora Update System 2015-01-26 02:36:24 UTC
python-invoke-0.9.0-4.fc21 has been pushed to the Fedora 21 stable repository.

Note You need to log in before you can comment on or make changes to this bug.