Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1165181

Summary: refactor vdsm sos plugin avoiding to mix sos 2 and sos 3 code
Product: [Retired] oVirt Reporter: Sandro Bonazzola <sbonazzo>
Component: vdsmAssignee: Yeela Kaplan <ykaplan>
Status: CLOSED DUPLICATE QA Contact: Gil Klein <gklein>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5CC: bazulay, bmr, bugs, ecohen, gklein, iheim, lsurette, mgoldboi, oourfali, rbalakri, ybronhei, yeylon
Target Milestone: ---   
Target Release: 3.5.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1168500 (view as bug list) Environment:
Last Closed: 2015-01-14 12:15:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1168500    

Description Sandro Bonazzola 2014-11-18 14:10:48 UTC 
Current VDSM sos plugin try to monkeypatch sos API for being compatible with bot sos 2 and sos 3 API with the result of being broken on both systems.

Please split the plugin in sos2/vdsm.py and sos3/vdsm.py and install only the relevant plugin for the sos version in use.

I would suggest again to move vdsm plugin to upstream sos project allowing sos maintainers to rebase the plugin when the sos API changes and extend it for other distributions. SOS maintainers are still keeping sos 2 branch alive for RHEL 6 support so it would be fine for EPEL6.

If you can't wait for a new sos release for introducing changes in the plugin we can build from their git and release within ovirt repo.
Comment 1 Bryn M. Reeves 2014-11-18 14:20:59 UTC 
I'm in agreement with Sandro: I'd have a strong preference to have this all pushed through upstream and to allow the maintainers of the downstream distros (RHEL6, RHEL7 and other products that ship sos) to include appropriate versions of the plugin for the release in which it is shipped.

There are other alternatives but they all involve considerable additional maintenance overheads.
Comment 2 Sandro Bonazzola 2014-11-27 07:33:08 UTC 
Moving from RFE to regular BZ and retargeting to 3.5.z since the monkey patching is breaking things at several levels.
Comment 3 Yaniv Bronhaim 2015-01-14 12:15:26 UTC 

*** This bug has been marked as a duplicate of bug 1168500 ***