Bug 1168500 - Move sos vdsm plugin to sos package
Summary: Move sos vdsm plugin to sos package
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: vdsm
Classification: oVirt
Component: General
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Oved Ourfali
QA Contact: Gonza
URL:
Whiteboard:
: 1165181 (view as bug list)
Depends On: 1165181
Blocks: 1167828
TreeView+ depends on / blocked
 
Reported: 2014-11-27 07:34 UTC by Sandro Bonazzola
Modified: 2022-07-05 14:02 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1165181
Environment:
Last Closed: 2016-03-15 06:53:43 UTC
oVirt Team: Infra
Embargoed:


Attachments (Terms of Use)
patch sent to sos upstream (5.67 KB, patch)
2015-06-11 14:07 UTC, Yeela Kaplan
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-46993 0 None None None 2022-07-05 14:02:52 UTC
oVirt gerrit 42425 0 master ABANDONED [WIP]sos: move plugin out of vdsm into sos package 2016-01-24 01:55:19 UTC

Description Sandro Bonazzola 2014-11-27 07:34:38 UTC
+++ This bug was initially created as a clone of Bug #1165181 +++

Current VDSM sos plugin try to monkeypatch sos API for being compatible with bot sos 2 and sos 3 API with the result of being broken on both systems.

Please split the plugin in sos2/vdsm.py and sos3/vdsm.py and install only the relevant plugin for the sos version in use.

I would suggest again to move vdsm plugin to upstream sos project allowing sos maintainers to rebase the plugin when the sos API changes and extend it for other distributions. SOS maintainers are still keeping sos 2 branch alive for RHEL 6 support so it would be fine for EPEL6.

If you can't wait for a new sos release for introducing changes in the plugin we can build from their git and release within ovirt repo.

--- Additional comment from Bryn M. Reeves on 2014-11-18 09:20:59 EST ---

I'm in agreement with Sandro: I'd have a strong preference to have this all pushed through upstream and to allow the maintainers of the downstream distros (RHEL6, RHEL7 and other products that ship sos) to include appropriate versions of the plugin for the release in which it is shipped.

There are other alternatives but they all involve considerable additional maintenance overheads.

--- Additional comment from Sandro Bonazzola on 2014-11-27 02:33:08 EST ---

Moving from RFE to regular BZ and retargeting to 3.5.z since the monkey patching is breaking things at several levels.

Comment 1 Oved Ourfali 2014-12-07 13:07:33 UTC
Moving to 3.5.1, as a suitable workaround was proposed by fixing Bug 1167828.

Comment 2 Yaniv Bronhaim 2015-01-14 12:15:26 UTC
*** Bug 1165181 has been marked as a duplicate of this bug. ***

Comment 3 Oved Ourfali 2015-01-20 13:44:39 UTC
Reducing severity, as there is a workaround. See comment #1.

Comment 4 Oved Ourfali 2015-06-11 07:32:04 UTC
Yeela - Please move to POST, and attach the patch you've sent.

Comment 5 Yeela Kaplan 2015-06-11 14:07:09 UTC
Created attachment 1037711 [details]
patch sent to sos upstream

Comment 7 Martin Perina 2016-03-02 12:09:10 UTC
Change status back to NEW as original patch was abandoned.


Note You need to log in before you can comment on or make changes to this bug.