Spec URL: https://dbruno.fedorapeople.org/cloudmonkey/cloudmonkey.spec SRPM URL: https://dbruno.fedorapeople.org/cloudmonkey/cloudmonkey-5.3.0-1.fc20.src.rpm Description: cloudmonkey is a command line interface (CLI) tool for CloudStack written in Python. cloudmonkey can be use both as an interactive shell and as a command line tool which simplifies CS configuration and management. Fedora Account System Username: dbruno
This package seems to have some issues (see below). I'm not yet a maintainer, as I haven't been sponsored, so this comment is unofficial. Shouldn't the package be named "apache-cloudstack-cloudmonkey" instead of "cloudmonkey"? It would remove possible confusion with https://www.cloudmonkey.co.uk/ and respect Apache trademark. Note that Cloudmonkey is not compatible with Python 3, so it's ok to package it with Python 2. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Version 5.3.3 of Cloudmonkey has been released (version packaged: 5.3.0) - Sources cannot be downloaded from https://pypi.python.org/ anymore: https://pypi.python.org/packages/source/c/cloudmonkey/cloudmonkey-5.3.0.tar.gz returns a HTTP 404 error. Cloudmonkey source tarball URL is listed on http://cloudstack.apache.org/downloads.html; latest version can be downloaded here: http://apache.mirrors.ovh.net/ftp.apache.org/dist/cloudstack/releases/ cloudmonkey-5.3.3/apache-cloudstack-cloudmonkey-5.3.3-src.tar.bz2 Note that this version contains LICENSE file and README.md, as opposed to the previous pypi tarball. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Note: License is ASL 2.0 [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 10 files have unknown license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://pypi.python.org/packages/source/c/cloudmonkey/cloudmonkey-5.3.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [x]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Note: there was no license text in tarball but there now is one. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [?]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cloudmonkey-5.3.0-1.fc25.noarch.rpm cloudmonkey-5.3.0-1.fc25.src.rpm cloudmonkey.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cloudmonkey/cloudmonkey.py 644 /usr/bin/python cloudmonkey.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cloudmonkey/requester.py 644 /usr/bin/python cloudmonkey.noarch: W: no-manual-page-for-binary cloudmonkey cloudmonkey.src: W: invalid-url Source0: https://pypi.python.org/packages/source/c/cloudmonkey/cloudmonkey-5.3.0.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 2 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- cloudmonkey.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cloudmonkey/requester.py 644 /usr/bin/python cloudmonkey.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cloudmonkey/cloudmonkey.py 644 /usr/bin/python cloudmonkey.noarch: W: no-manual-page-for-binary cloudmonkey 1 packages and 0 specfiles checked; 2 errors, 1 warnings. Requires -------- cloudmonkey (rpmlib, GLIBC filtered): /usr/bin/python python(abi) python-argcomplete python-prettytable python-pygments python-requests Provides -------- cloudmonkey: cloudmonkey python2.7dist(cloudmonkey) python2dist(cloudmonkey)
Hi Daniel, Do you still want to see work on this package? CloudMonkey has evolved a lot since your wrote that spec (rewritten from Python to Golang, changed home, etc)?
Hi Daniel, Please respond to this ticket if you want to keep it open.
- Not ok: %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} %{python_sitelib}/* You must use %{python3_sitelib}/ and be more specific as we forbid globbing the entire directory - Group is not used in Fedora - Not needed: %defattr(-,root,root,-) rm -rf %{buildroot} %clean rm -rf %{buildroot} BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Python 2 is deprecated, you must package Python 3 only. - Source0: https://pypi.python.org/packages/source/c/cloudmonkey/%{tarball_name}-%{version}.tar.gz → Source0: %{pypi_source} - %{__python} setup.py build → %py3_build - %{__python} setup.py install -O1 --skip-build --root %{buildroot} → %py3_install
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.