Spec URL: https://piotrp.fedorapeople.org/nodejs-domhandler.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-domhandler-2.3.0-1.fc21.src.rpm Description: Handler for htmlparser2 that turns pages into a dom Fedora Account System Username: piotrp
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-domhandler.noarch: W: spelling-error Summary(en_US) dom -> mod, dim, don nodejs-domhandler.noarch: W: spelling-error %description -l en_US dom -> mod, dim, don nodejs-domhandler.noarch: W: only-non-binary-in-usr-lib nodejs-domhandler.noarch: W: dangling-symlink /usr/lib/node_modules/domhandler/node_modules/domelementtype /usr/lib/node_modules/domelementtype nodejs-domhandler.src: W: spelling-error Summary(en_US) dom -> mod, dim, don nodejs-domhandler.src: W: spelling-error %description -l en_US dom -> mod, dim, don 2 packages and 0 specfiles checked; 0 errors, 6 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 526cb3635c411ee00bc222897010cecf3a5cbbe0104d143c73af3265f0e85d14 upstream tarball: 526cb3635c411ee00bc222897010cecf3a5cbbe0104d143c73af3265f0e85d14 - License is "BSD", not "MIT" + License text is included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Group tag is optional, can be removed. 2) Fix license tag.
Thank you for review, I promise to be more careful with the license tag in future packages. fixed in: Spec URL: https://piotrp.fedorapeople.org/nodejs-domhandler.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-domhandler-2.3.0-2.fc21.src.rpm
Looks good now APPROVED.
New Package SCM Request ======================= Package Name: nodejs-domhandler Short Description: Handler for htmlparser2 that turns pages into a dom Upstream URL: https://github.com/fb55/DomHandler Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: piotrp
Git done (by process-git-requests).
nodejs-domhandler-2.3.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-domhandler-2.3.0-2.el7
nodejs-domhandler-2.3.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-domhandler-2.3.0-2.fc21
nodejs-domhandler-2.3.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-domhandler-2.3.0-2.fc20
nodejs-domhandler-2.3.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-domhandler-2.3.0-2.fc19
nodejs-domhandler-2.3.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
Package built and in testing, closing bug.
nodejs-domhandler-2.3.0-2.fc19 has been pushed to the Fedora 19 stable repository.
nodejs-domhandler-2.3.0-2.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-domhandler-2.3.0-2.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-domhandler-2.3.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.