Spec URL: https://piotrp.fedorapeople.org/nodejs-domelementtype.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-domelementtype-1.1.3-1.fc21.src.rpm Description: All the types of nodes in htmlparser2's dom Fedora Account System Username: piotrp
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-domelementtype.noarch: W: spelling-error Summary(en_US) dom -> mod, dim, don nodejs-domelementtype.noarch: W: spelling-error %description -l en_US dom -> mod, dim, don nodejs-domelementtype.noarch: W: only-non-binary-in-usr-lib nodejs-domelementtype.src: W: spelling-error Summary(en_US) dom -> mod, dim, don nodejs-domelementtype.src: W: spelling-error %description -l en_US dom -> mod, dim, don 2 packages and 0 specfiles checked; 0 errors, 5 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 40e96adc53a1535e0cdde455d6b2cfcaf80f459ba825c040e9705dfd49bf64f3 upstream tarball: 40e96adc53a1535e0cdde455d6b2cfcaf80f459ba825c040e9705dfd49bf64f3 - License is "BSD" but in spec its written "MIT" + License test is included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Group tag is optional and can be removed. 2) Fix license tag.
Thank you for review, Fixed suggestions: Spec URL: https://piotrp.fedorapeople.org/nodejs-domelementtype.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-domelementtype-1.1.3-2.fc21.src.rpm
Looks good. APPROVED.
No SCM request.
New Package SCM Request ======================= Package Name: nodejs-domelementtype Short Description: All the types of nodes in htmlparser2's dom Upstream URL: https://github.com/FB55/domelementtype Owners: piotrp Branches: f19 f20 f21 el6 epel7
Git done (by process-git-requests).
nodejs-domelementtype-1.1.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.fc21
nodejs-domelementtype-1.1.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.fc20
nodejs-domelementtype-1.1.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.fc19
nodejs-domelementtype-1.1.3-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-domelementtype-1.1.3-2.el7
nodejs-domelementtype-1.1.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
Package built and in testing, closing bug.
nodejs-domelementtype-1.1.3-2.fc19 has been pushed to the Fedora 19 stable repository.
nodejs-domelementtype-1.1.3-2.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-domelementtype-1.1.3-2.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-domelementtype-1.1.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository.