Bug 1169530 - headers with different cases are not merged
Summary: headers with different cases are not merged
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-requests
Version: 5.0 (RHEL 7)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: z4
: 5.0 (RHEL 7)
Assignee: hguemar
QA Contact: Ami Jeain
URL:
Whiteboard:
Depends On:
Blocks: 1135135 1176181 1176186 1183150 1202548 1232881
TreeView+ depends on / blocked
 
Reported: 2014-12-01 22:50 UTC by Josh Durgin
Modified: 2023-02-22 23:02 UTC (History)
12 users (show)

Fixed In Version: python-requests-2.3.0-1.el7
Doc Type: Rebase: Bug Fixes and Enhancements
Doc Text:
Clone Of:
: 1176181 1176186 1202548 (view as bug list)
Environment:
Last Closed: 2015-04-16 14:37:44 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
upstream fix for python-requests-1.1.0-8.1.el7ost package (4.00 KB, patch)
2014-12-01 22:50 UTC, Josh Durgin
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:0825 0 normal SHIPPED_LIVE Red Hat Enterprise Linux OpenStack Platform Bug Fix and Enhancement Advisory 2015-04-16 18:28:14 UTC

Description Josh Durgin 2014-12-01 22:50:55 UTC
Created attachment 963430 [details]
upstream fix for python-requests-1.1.0-8.1.el7ost package

Description of problem:

The high-level problem is https://bugzilla.redhat.com/show_bug.cgi?id=1135135

The root cause is python-requests having a buggy implementation of a case
insensitive mapping. When swiftclient adds a 'Content-Length' header and requests implicitly adds a 'content-length' header, requests sends both as separate headers. This causes apache to reject the request with a 400 error.

Version-Release number of selected component (if applicable):

python-requests-1.1.0-8.1.el7ost

How reproducible:

always

Steps to Reproduce:

Run this testcase:
https://github.com/kennethreitz/requests/blob/f7596c75dce4e87ab83bdf74e8f120a4b1a5ff03/test_requests.py#L514

Additional info:

This was fixed upstream in https://github.com/kennethreitz/requests/issues/649
The fix as a patch against the current package is attached.

Comment 2 Lon Hohberger 2014-12-19 15:32:31 UTC
python-requests-2.3.0-3.el7ost is in RHEL OSP 6 beta.

Comment 3 Lon Hohberger 2014-12-19 15:39:25 UTC
It's probable that rebasing to python-requests 2.3.0 is how we should fix this; this was addressed in commit f7596c75 of upstream master.

Comment 10 Ami Jeain 2015-03-30 12:08:28 UTC
verified:
ran https://github.com/kennethreitz/requests/blob/f7596c75dce4e87ab83bdf74e8f120a4b1a5ff03/test_requests.py and verified that only valid errors occur

Comment 13 errata-xmlrpc 2015-04-16 14:37:44 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0825.html


Note You need to log in before you can comment on or make changes to this bug.