Bug 1176181 – headers with different cases are not merged

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1176181 - headers with different cases are not merged

Summary:	headers with different cases are not merged

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat OpenStack
Classification:	Red Hat
Component:	python-requests (Show other bugs)
Sub Component:
Version:	5.0 (RHEL 6)
Hardware:	Unspecified Unspecified

Priority	high Severity high
Target Milestone:	z4
Target Release:	5.0 (RHEL 6)
Assigned To:	hguemar
QA Contact:	Ami Jeain
Docs Contact:

URL:
Whiteboard:
Keywords:	Rebase, ZStream

Depends On:	1169530 1176186 1202548 1206465 1232881
Blocks:	1135135 1183150 1199249
	Show dependency tree / graph

Reported:	2014-12-19 10:59 EST by hguemar
Modified:	2016-04-26 17:19 EDT (History)
CC List:	9 users (show)

See Also:
Fixed In Version:	python-requests-2.3.0-1.el6
Doc Type:	Rebase: Bug Fixes and Enhancements
Doc Text:	In the previous version, python-requests had issues including incorrect HTTP headers’ generation, causing errors with python-swiftclient. This was due to python-requests having an incorrect implementation of a case insensitive mapping. With this release, case insensitive dictionary (CaseInsensitiveDict) has been updated which has fixed all issues with python-swiftclient.
Story Points:	---
Clone Of:	1169530
Clones:	1183150 (view as bug list)
Environment:
Last Closed:	2015-04-16 10:37:59 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2015:0820	normal	SHIPPED_LIVE	Red Hat Enterprise Linux OpenStack Platform Bug Fix and Enhancement Advisory	2015-04-16 14:28:41 EDT

Groups: None (edit)

Comment 1 Lon Hohberger 2014-12-19 11:01:50 EST

+++ This bug was initially created as a clone of Bug #1169530 +++

Description of problem:

The high-level problem is https://bugzilla.redhat.com/show_bug.cgi?id=1135135

The root cause is python-requests having a buggy implementation of a case
insensitive mapping. When swiftclient adds a 'Content-Length' header and requests implicitly adds a 'content-length' header, requests sends both as separate headers. This causes apache to reject the request with a 400 error.

Version-Release number of selected component (if applicable):

python-requests-1.1.0-8.1.el7ost

How reproducible:

always

Steps to Reproduce:

Run this testcase:
https://github.com/kennethreitz/requests/blob/f7596c75dce4e87ab83bdf74e8f120a4b1a5ff03/test_requests.py#L514

Additional info:

This was fixed upstream in https://github.com/kennethreitz/requests/issues/649
The fix as a patch against the current package is attached.

--- Additional comment from Lon Hohberger on 2014-12-19 10:32:31 EST ---

python-requests-2.3.0-3.el7ost is in RHEL OSP 6 beta.

--- Additional comment from Lon Hohberger on 2014-12-19 10:39:25 EST ---

It's probable that rebasing to python-requests 2.3.0 is how we should fix this; this was addressed in commit f7596c75 of upstream master.

Comment 2 hguemar 2015-03-03 11:33:48 EST

Fixed in LPC

Comment 4 Ami Jeain 2015-03-31 02:37:17 EDT

verified:
ran the script from https://github.com/kennethreitz/requests/blob/f7596c75dce4e87ab83bdf74e8f120a4b1a5ff03/test_requests.py

Comment 6 errata-xmlrpc 2015-04-16 10:37:59 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0820.html

Note You need to log in before you can comment on or make changes to this bug.