Bug 1170812 - Review Request: nodejs-astral - AST tooling framework for JavaScript
Summary: Review Request: nodejs-astral - AST tooling framework for JavaScript
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1170811
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-12-04 22:33 UTC by Piotr Popieluch
Modified: 2014-12-28 20:42 UTC (History)
2 users (show)

Fixed In Version: nodejs-astral-0.1.0-2.el7
Clone Of:
Environment:
Last Closed: 2014-12-14 12:35:12 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Piotr Popieluch 2014-12-04 22:33:05 UTC
Spec URL: https://piotrp.fedorapeople.org/nodejs-astral.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-astral-0.1.0-1.fc21.src.rpm
Description: AST tooling framework for JavaScript
Fedora Account System Username: piotrp

Comment 1 Parag AN(पराग) 2014-12-06 16:56:23 UTC
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-astral.noarch: W: spelling-error %description -l en_US modularity -> molecularity
nodejs-astral.noarch: W: spelling-error %description -l en_US llvm -> llama
nodejs-astral.noarch: W: only-non-binary-in-usr-lib
nodejs-astral.noarch: W: dangling-symlink /usr/lib/node_modules/astral/node_modules/clone /usr/lib/node_modules/clone
nodejs-astral.src: W: spelling-error %description -l en_US modularity -> molecularity
nodejs-astral.src: W: spelling-error %description -l en_US llvm -> llama
2 packages and 0 specfiles checked; 0 errors, 6 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball: 705a7fd67fe7ccff2d965bdfc8fcc70021e5938efb07998ee378424425f1e04f
upstream tarball:  
705a7fd67fe7ccff2d965bdfc8fcc70021e5938efb07998ee378424425f1e04f

+ License is "MIT" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed.

2) Should ask upstream to add license text

Comment 3 Parag AN(पराग) 2014-12-07 17:54:42 UTC
Looks good now. Don't forget to keep asking upstream to include license text and when available update the package.

APPROVED.

Comment 4 Piotr Popieluch 2014-12-07 18:09:15 UTC
New Package SCM Request
=======================
Package Name: nodejs-astral
Short Description: AST tooling framework for JavaScript
Upstream URL: https://github.com/btford/astral
Owners: piotrp
Branches: f19 f20 f21 el6 epel7
InitialCC:

Comment 5 Gwyn Ciesla 2014-12-08 14:12:52 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-12-11 07:07:52 UTC
nodejs-astral-0.1.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-astral-0.1.0-2.fc20

Comment 7 Fedora Update System 2014-12-11 07:08:32 UTC
nodejs-astral-0.1.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-astral-0.1.0-2.fc19

Comment 8 Fedora Update System 2014-12-11 07:09:32 UTC
nodejs-astral-0.1.0-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nodejs-astral-0.1.0-2.el7

Comment 9 Fedora Update System 2014-12-12 23:07:07 UTC
nodejs-astral-0.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository.

Comment 10 Piotr Popieluch 2014-12-14 12:35:12 UTC
Package built and in testing, closing bug.

Comment 11 Fedora Update System 2014-12-21 06:35:33 UTC
nodejs-astral-0.1.0-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 12 Fedora Update System 2014-12-21 06:40:58 UTC
nodejs-astral-0.1.0-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2014-12-28 20:42:41 UTC
nodejs-astral-0.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.