Bug 1171106 - hack to avoid RPATH with old libtool-ed tarballs
Summary: hack to avoid RPATH with old libtool-ed tarballs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Festi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1158915
TreeView+ depends on / blocked
 
Reported: 2014-12-05 10:58 UTC by Pavel Raiskup
Modified: 2019-12-03 14:31 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-03 14:31:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch: avoid rpath with libtool (4.91 KB, patch)
2014-12-05 10:58 UTC, Pavel Raiskup
no flags Details | Diff

Description Pavel Raiskup 2014-12-05 10:58:59 UTC
Created attachment 965075 [details]
Patch: avoid rpath with libtool

Libtool at least up to v2.4.4 did not consider the /lib64 /usr/lib64 to be the
system default ("trusted") library path on linux.  However, from v2.2, there
is possible to say to libtool what the paths are via
lt_cv_sys_lib_dlsearch_path_spec env variable.  Because setting this variable
disables also the ld.so.conf parser, simply setting
lt_cv_sys_lib_dlsearch_path_spec="%{_libdir}" is not enough.

Could we please consider adding something like attached patch?  It is using
the lt_cv_sys_lib_dlsearch_path_spec is documented way [1].

Benefits:
* according to glibc's guys, distributions should define what the library
  directories are [2], redhat-rpm-config has now better control

* the importance of guidelines related to RPATH [3] will became smaller, as
  for most cases the %configure macro will solve that for us

Note there is no opt-out option for this hack as it is not needed, users may
simply export this variable themselves to opt-out.

[1] https://www.gnu.org/software/libtool/manual/html_node/Configure-notes.html

[2] http://comments.gmane.org/gmane.comp.lib.glibc.alpha/13815
    http://comments.gmane.org/gmane.comp.lib.glibc.alpha/19256

[3] https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath

Pavel

Comment 1 Fedora End Of Life 2015-05-29 13:27:49 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 2 Fedora End Of Life 2015-11-04 11:38:26 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Pavel Raiskup 2015-11-04 11:57:20 UTC
Ping.

Comment 4 Fedora End Of Life 2016-07-19 12:28:53 UTC
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 5 Pavel Raiskup 2019-03-28 13:00:00 UTC
Slightly less intrusive solution (for libtool 2.4.6+ only, though)
https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/55

Comment 6 Panu Matilainen 2019-12-03 14:31:14 UTC
https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/55 got merged, closing. I have to say I prefer the newer variant a great deal more than the originally proposed fix.


Note You need to log in before you can comment on or make changes to this bug.