Spec URL: http://acksyn.org/files/rpms/beets/beets.spec SRPM URL: http://acksyn.org/files/rpms/beets/beets-1.3.9-1.fc22.src.rpm Description: The purpose of beets is to get your music collection right once and for all. It catalogs your collection, automatically improving its meta-data as it goes using the MusicBrainz database. Then it provides a bouquet of tools for manipulating and accessing your music. Because beets is designed as a library, it can do almost anything you can imagine for your music collection. Via plugins, beets becomes a panacea: - Fetch or calculate all the meta-data you could possibly need: album art, lyrics, genres, tempos, ReplayGain levels, or acoustic fingerprints. - Get meta-data from MusicBrainz, Discogs, or Beatport. Or guess meta-data using songs' file names or their acoustic fingerprints. - Transcode audio to any format you like. - Check your library for duplicate tracks and albums or for albums that are missing tracks. - Browse your music library graphically through a Web browser and play it in any browser that supports HTML5 Audio. Fedora Account System Username: mbaldessari
You are missing quite a few optional plugin dependencies. I'd suggest either removing those plugins or actually pulling in the dependencies. One possibility would be to add per-plugin %package declarations so you don't pull in unnecessary things but allow people to install optionally. See http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-sound/beets/beets-1.3.3-r1.ebuild?view=markup for example of missed things. It's an older version so there might be more things missing...
Hi Stanislav, thanks for the comments. Yes, I need to think a bit more about this: - Some plugins require packages that only exist in rpmfusion (mp3gain) - Another plugin actually ships jquery and some more libs (so it would make sense to wait for jquery to hit the archive and then depend on it for this plugin) Unless you have a better idea, I'll probably try and split off the plugins in one single separate beets-plugins packages and I will disable those that depend on rpmfusion packages (at least when I was working on Debian this was a must otherwise the package had to go in contrib and not in main). cheers, Michele
Spec URL: http://acksyn.org/files/rpms/beets/beets.spec SRPM URL: http://acksyn.org/files/rpms/beets/beets-1.3.9-2.fc22.src.rpm For now I've disabled the following plugins (due to dependencies not existing in Fedora): - echonest - echonest_tempo - replaygain - web - convert - discogs The plugins were split off into a separate package. Thanks, Michele
New upstream: Spec URL: http://acksyn.org/files/rpms/beets/beets.spec SRPM URL: http://acksyn.org/files/rpms/beets/beets-1.3.10-1.fc22.src.rpm
Please, use parallel make: make %{?_smp_mflags} I'd also recommend to build the documentation in text and html format and place it in a -doc subpackage.
Thanks for the review, Juan I have split off the doc in a separate -doc package. I have also added a comment as to why I am not using _smp_flags in the sphinx doc build (sphinx barfs out from time to time at the moment. There are some upstream issues related to this. Will need to track those down) Spec URL: http://acksyn.org/files/rpms/beets/beets.spec SRPM URL: http://acksyn.org/files/rpms/beets/beets-1.3.10-2.fc23.src.rpm
I'll do the review. Some points to modify: - Please, add ISC as the license of the file beetsplug/mbcollection.py - Use %{__python2} and %{python2_sitelib} to be prepared for https://fedoraproject.org/wiki/Changes/Python_3_as_Default - Some files / dirs have no owner: /usr/lib/python2.7/site- packages/beets-1.3.10-py2.7.egg-info, /usr/lib/python2.7/site- packages/beetsplug, /usr/lib/python2.7/site-packages/beets
Thanks Juan, I have added ISC, changed python macros and fixed the ownership of those dirs: http://acksyn.org/files/rpms/beets/beets-1.3.10-3.fc23.src.rpm http://acksyn.org/files/rpms/beets/beets.spec Cheers, Michele
The spec file doesn't match the one in the srpm. Please, add a comment about the license explaining that only beetsplug/mbcollection.py is licensed as ISC. Everything else looks fine now. Please, do these changes and I'll do the final review.
Hi Juan, sorry, I uploaded a mock rebuild that did not have the last python2 changes in the spec file. Here the newer ones (I did not bumb the revision, hope that is ok): http://acksyn.org/files/rpms/beets/beets.spec http://acksyn.org/files/rpms/beets/beets-1.3.10-3.fc23.src.rpm I have now moved the comment about the ISC license of beetsplugin/mbcollection in the proper %files plugins, section as per http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios thanks again, Michele
Package is APPROVED. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. Python: [x]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python Note: Test run failed [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [x]: Uses parallel make %{?_smp_mflags} macro. Note: parallel make disabled due to bugs [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. Note: checks disabled because it is forcing the download of pypi modules [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: beets-1.3.10-3.fc21.noarch.rpm beets-plugins-1.3.10-3.fc21.noarch.rpm beets-doc-1.3.10-3.fc21.noarch.rpm beets-1.3.10-3.fc21.src.rpm beets-plugins.noarch: W: spelling-error %description -l en_US operability -> penetrability, permeability, probability beets-plugins.noarch: W: invalid-url URL: http://beets.radbox.org/ [Errno 104] Connection reset by peer beets-plugins.noarch: W: no-documentation beets-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/beets-doc/html/_static/jquery.js 4 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- beets-plugins (rpmlib, GLIBC filtered): beets gstreamer-python pylast python(abi) python-acoustid python-mpd python-musicbrainzngs python-requests beets (rpmlib, GLIBC filtered): /usr/bin/python2 PyYAML python python(abi) python-enum34 python-mutagen python-unidecode beets-doc (rpmlib, GLIBC filtered): Provides -------- beets-plugins: beets-plugins beets: beets beets-doc: beets-doc Source checksums ---------------- https://github.com/sampsyo/beets/archive/v1.3.10.tar.gz : CHECKSUM(SHA256) this package : 6413fd181f57b7e8fcc070b5c2cccd6f3694fb76f8487205d5ae03cbd75a899c CHECKSUM(SHA256) upstream package : 6413fd181f57b7e8fcc070b5c2cccd6f3694fb76f8487205d5ae03cbd75a899c
New Package SCM Request ======================= Package Name: beets Short Description: beets - Music library manager and MusicBrainz tagger Upstream URL: http://beets.radbox.org/ Owners: mbaldessari Branches: f22 InitialCC:
(In reply to Juan Orti from comment #11) > [x]: Package functions as described. No, the package is not working because of a missing dep. [fab@laptop017 noarch]$ beet Traceback (most recent call last): File "/usr/bin/beet", line 5, in <module> from pkg_resources import load_entry_point File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 2709, in <module> working_set.require(__requires__) File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 664, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 567, in resolve raise DistributionNotFound(req) pkg_resources.DistributionNotFound: munkres
As long as the test are not enabled, python-rarfile is not a dependency.
Git done (by process-git-requests).
You're correct about the munkres dep. I had it on my system and for some reason was reasonably sure it came from a package. I will wait for your munkres package before pushing any builds
I didn't notice it because I'm a regular user of beets and that library was also installed in my system. That's my fault, I'm sorry.
The latest 1.3.11 beets package requires python-enum34 1.0.4. Adding BZ blocker accordingly (BZ 1210053)
1.3.11 is now in rawhide. 1.3.12 introduced a new dependency (python-jellyfish). I will chase this in another BZ