Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-munkres.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-munkres-1.0.7-1.fc21.src.rpm Project URL: http://software.clapper.org/munkres/ Description: The Munkres module provides an implementation of the Munkres algorithm (also called the Hungarian algorithm or the Kuhn-Munkres algorithm). The algorithm models an assignment problem as an NxM cost matrix, where each element represents the cost of assigning the ith worker to the jth job, and it figures out the least-cost solution, choosing a single item from each row and column in the matrix, such that no row and no column are used more than once. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9239067 rpmlint output: [fab@laptop017 SRPMS]$ rpmlint python-munkres-1.0.7-1.fc21.src.rpm python-munkres.src: W: spelling-error %description -l en_US ith -> it, itch, pith python-munkres.src: W: spelling-error %description -l en_US jth -> nth, 5th 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [fab@laptop017 noarch]$ rpmlint python*-munk* python3-munkres.noarch: W: spelling-error %description -l en_US ith -> it, itch, pith python3-munkres.noarch: W: spelling-error %description -l en_US jth -> nth, 5th python-munkres.noarch: W: spelling-error %description -l en_US ith -> it, itch, pith python-munkres.noarch: W: spelling-error %description -l en_US jth -> nth, 5th 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Fedora Account System Username: fab
*** Bug 1008058 has been marked as a duplicate of this bug. ***
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find LICENSE in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text The above is moot and is a bug in fedora-review (BZ 1199414). Package contains proper %license fields. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/michele/Fedora/Packages/python-munkres-1.0.7 /review-python-munkres/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [-]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [-]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-munkres [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-munkres-1.0.7-1.fc22.noarch.rpm python3-munkres-1.0.7-1.fc22.noarch.rpm python-munkres-1.0.7-1.fc22.src.rpm python-munkres.noarch: W: spelling-error %description -l en_US ith -> it, itch, pith python-munkres.noarch: W: spelling-error %description -l en_US jth -> nth, Th python3-munkres.noarch: W: spelling-error %description -l en_US ith -> it, itch, pith python3-munkres.noarch: W: spelling-error %description -l en_US jth -> nth, Th python-munkres.src: W: spelling-error %description -l en_US ith -> it, itch, pith python-munkres.src: W: spelling-error %description -l en_US jth -> nth, Th 3 packages and 0 specfiles checked; 0 errors, 6 warnings. Requires -------- python-munkres (rpmlib, GLIBC filtered): python(abi) python3-munkres (rpmlib, GLIBC filtered): python(abi) python3 Provides -------- python-munkres: python-munkres python3-munkres: python3-munkres Source checksums ---------------- https://pypi.python.org/packages/source/m/munkres/munkres-1.0.7.tar.gz : CHECKSUM(SHA256) this package : 334a5d849bcefed3e4c32ecfbca4ee8dfc8ef5f2f181334d6f7f4e100b71d6c4 CHECKSUM(SHA256) upstream package : 334a5d849bcefed3e4c32ecfbca4ee8dfc8ef5f2f181334d6f7f4e100b71d6c4 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -n python-munkres Review is ACCEPT, setting fedora-review flag to +
Thanks for the review.
New Package SCM Request ======================= Package Name: python-munkres Short Description: A Munkres algorithm for Python Upstream URL: http://software.clapper.org/munkres/ Owners: fab Branches: f22 f21 epel7 el6 InitialCC:
Git done (by process-git-requests).
python-munkres-1.0.7-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-munkres-1.0.7-1.fc22
python-munkres-1.0.7-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-munkres-1.0.7-1.fc21
python-munkres-1.0.7-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-munkres-1.0.7-1.el7
python-munkres-1.0.7-1.fc22 has been pushed to the Fedora 22 testing repository.
python-munkres-1.0.7-1.fc22 has been pushed to the Fedora 22 stable repository.
python-munkres-1.0.7-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
python-munkres-1.0.7-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.