Bug 1178939 - enet-devel is missing pkgconfig file
Summary: enet-devel is missing pkgconfig file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: enet
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: François Cami
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1077703
TreeView+ depends on / blocked
 
Reported: 2015-01-05 17:13 UTC by Michal Schmidt
Modified: 2015-06-11 18:34 UTC (History)
4 users (show)

Fixed In Version: enet-1.3.12-4.fc21
Clone Of:
Environment:
Last Closed: 2015-01-05 23:00:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
[PATCH] Ship *.pc file, cleanup spec file (2.47 KB, patch)
2015-01-05 17:13 UTC, Michal Schmidt
no flags Details | Diff

Description Michal Schmidt 2015-01-05 17:13:53 UTC
Created attachment 976526 [details]
[PATCH] Ship *.pc file, cleanup spec file

Description of problem:
Upstream tarball contains a pkgconfig file and "make install" would install it, but it is not packaged in enet-devel.

Version-Release number of selected component (if applicable):
enet-devel-1.3.12-3.fc21.x86_64

How reproducible:
always

Steps to Reproduce:
1. rpm -ql enet-devel | grep pkgconfig
2.
3.

Actual results:
empty

Expected results:
/usr/lib64/pkgconfig/libenet.pc

Additional info:
I'm attaching a proposed spec file patch.

Comment 1 François Cami 2015-01-05 20:53:21 UTC
hi Michal, I'm quite happy with the patch, thank you. Bruno, Hans, Marcel, any objection or comment?

Comment 2 Bruno Wolff III 2015-01-05 21:47:35 UTC
I went through the patch and it seems pretty reasonable. I didn't check the pc file. Be sure to check that multilib got hadnled correctly.

Comment 3 François Cami 2015-01-05 22:39:28 UTC
multilib seems handled correctly to me, thanks for pointing that out.

i386 and x86_64 scratch builds available at:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8534063
http://koji.fedoraproject.org/koji/taskinfo?taskID=8534124

$ cat i386/usr/lib/pkgconfig/libenet.pc
prefix=/usr
exec_prefix=/usr
libdir=/usr/lib
includedir=/usr/include

Name: libenet
Description: Low-latency UDP networking library supporting optional reliability
Version: 1.3.12
Cflags: -I${includedir}
Libs: -L${libdir} -lenet

$ diff -U0 i386/usr/lib/pkgconfig/libenet.pc x86_64/usr/lib64/pkgconfig/libenet.pc
--- i386/usr/lib/pkgconfig/libenet.pc	2015-01-05 23:27:07.409392781 +0100
+++ x86_64/usr/lib64/pkgconfig/libenet.pc	2015-01-05 23:26:55.206369273 +0100
@@ -3 +3 @@
-libdir=/usr/lib
+libdir=/usr/lib64

Comment 4 François Cami 2015-01-05 23:00:07 UTC
Pushed and built:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8534305

Thanks Michal. Feel free to add yourself to the package in pkgdb.

Comment 5 Fedora Update System 2015-01-05 23:30:17 UTC
enet-1.3.12-4.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/enet-1.3.12-4.fc21

Comment 6 Fedora Update System 2015-06-11 18:34:50 UTC
enet-1.3.12-4.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.