Bug 1180522 - testJson*Disk* failures on F21 build
Summary: testJson*Disk* failures on F21 build
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.6
Hardware: Unspecified
OS: Unspecified
high
urgent
Target Milestone: m1
: 3.6.0
Assignee: Allon Mureinik
QA Contact: Aharon Canan
URL:
Whiteboard: storage
Depends On:
Blocks: oVirt_Fedora_21_Support 1180887
TreeView+ depends on / blocked
 
Reported: 2015-01-09 10:52 UTC by Sandro Bonazzola
Modified: 2016-03-10 06:17 UTC (History)
7 users (show)

Fixed In Version: ovirt-engine-3.6.0-0.0.master.20150412172306.git55ba764
Clone Of:
: 1180887 (view as bug list)
Environment:
Last Closed: 2015-11-04 11:30:22 UTC
oVirt Team: Storage
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 36753 0 master MERGED core: sorted getJsonDiskDescription() Never

Description Sandro Bonazzola 2015-01-09 10:52:24 UTC 
building engine master 040a8bb on fc21 I have:

Failed tests: 
  testJsonNullDiskDescription(org.ovirt.engine.core.bll.ImagesHandlerTest): Should be map of disk alias and disk description
  testJsonDiskDescription(org.ovirt.engine.core.bll.ImagesHandlerTest): Should be map of disk alias and disk description
  testJsonEmptyDiskDescription(org.ovirt.engine.core.bll.ImagesHandlerTest): Should be map of disk alias and disk description

See: http://jenkins.ovirt.org/job/manual-build-tarball/449/label=fc21/console for build logs.

Maybe something similar to http://gerrit.ovirt.org/36282 will solve the issue.
Comment 1 Allon Mureinik 2015-01-11 14:04:48 UTC 
Indeed. The code in the test implicitly assumes the order in which a HashMap is iterated over. This assumption definitely breaks when transition from JDK7 to JDK8, as evident by this BZ, but may very well happen in a numerous number of other slight changes in the environment.
Comment 2 Allon Mureinik 2015-04-13 18:21:33 UTC 
This change is to oVirt's unit testing code, and is not exposed to the QA.
The fact that the build passed proves it worked, marking as VERIFIED.
Comment 3 Sandro Bonazzola 2015-11-04 11:30:22 UTC 
oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.
Note You need to log in before you can comment on or make changes to this bug.