Bug 1180887 - testJson*Disk* failures on F21 build
Summary: testJson*Disk* failures on F21 build
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.5
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 3.5.1
Assignee: Allon Mureinik
QA Contact: Elad
URL:
Whiteboard: storage
Depends On: 1180522
Blocks: 1193058 1196662 1197441
TreeView+ depends on / blocked
 
Reported: 2015-01-11 14:12 UTC by Allon Mureinik
Modified: 2016-02-10 18:00 UTC (History)
11 users (show)

Fixed In Version: ovirt-3.5.1_rc1
Doc Type: Bug Fix
Doc Text:
Clone Of: 1180522
Environment:
Last Closed: 2015-03-23 12:25:34 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 36753 0 None None None Never
oVirt gerrit 36762 0 ovirt-engine-3.5 MERGED core: sorted getJsonDiskDescription() Never

Description Allon Mureinik 2015-01-11 14:12:28 UTC
+++ This bug was initially created as a clone of Bug #1180522 +++

building engine master 040a8bb on fc21 I have:

Failed tests: 
  testJsonNullDiskDescription(org.ovirt.engine.core.bll.ImagesHandlerTest): Should be map of disk alias and disk description
  testJsonDiskDescription(org.ovirt.engine.core.bll.ImagesHandlerTest): Should be map of disk alias and disk description
  testJsonEmptyDiskDescription(org.ovirt.engine.core.bll.ImagesHandlerTest): Should be map of disk alias and disk description

See: http://jenkins.ovirt.org/job/manual-build-tarball/449/label=fc21/console for build logs.

Maybe something similar to http://gerrit.ovirt.org/36282 will solve the issue.

--- Additional comment from Allon Mureinik on 2015-01-11 16:04:48 IST ---

Indeed. The code in the test implicitly assumes the order in which a HashMap is iterated over. This assumption definitely breaks when transition from JDK7 to JDK8, as evident by this BZ, but may very well happen in a numerous number of other slight changes in the environment.

=============================================================================
Although 3.5.1 does not need to support JDK8, this test is WAY too delicate to leave in this state - any minor update to the JDK may break the unit test suite.

Comment 1 Sandro Bonazzola 2015-01-15 14:15:37 UTC
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA

Comment 2 Allon Mureinik 2015-01-19 10:27:35 UTC
This is a CodeChange bug. The fact that we can construct an RPM on F21 proves this works.

Comment 3 Eyal Edri 2015-02-26 12:33:10 UTC
this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.

Comment 4 Allon Mureinik 2015-02-26 15:57:37 UTC
(In reply to Eyal Edri from comment #3)
> this ovirt bug was fixed during 3.5.1 cycle and is included in the build,
> and therefore should be verified.
The fact that the build passes verifies this bug.


Note You need to log in before you can comment on or make changes to this bug.