Bug 1181603 - [AAA] no warning when same profile name is specified in multiple extension
Summary: [AAA] no warning when same profile name is specified in multiple extension
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.5
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 3.5.1
Assignee: Alon Bar-Lev
QA Contact: Ondra Machacek
URL:
Whiteboard: infra
Depends On:
Blocks: oVirt-AAA-rewrite 1193058 1196662 1197441
TreeView+ depends on / blocked
 
Reported: 2015-01-13 12:58 UTC by Ondra Machacek
Modified: 2016-02-10 19:35 UTC (History)
8 users (show)

Fixed In Version: ovirt-3.5.1_rc1
Clone Of:
Environment:
Last Closed: 2015-09-04 12:48:04 UTC
oVirt Team: Infra
Embargoed:

Attachments (Terms of Use)
engine.log (56.42 KB, text/plain)
2015-01-13 13:16 UTC, Ondra Machacek 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 36850 0 master MERGED aaa: issue warning on duplicate profile name Never
oVirt gerrit 36857 0 ovirt-engine-3.5 MERGED aaa: issue warning on duplicate profile name Never

Description Ondra Machacek 2015-01-13 12:58:55 UTC 
Description of problem:


Version-Release number of selected component (if applicable):
3.5.0

How reproducible:
always

Steps to Reproduce:
1. rhevm-manage-domains add --domain=qa.lab.tlv.redhat.com --user=vdcadmin --provider=ad
2. create new ldap provider with such configuration:

ovirt.engine.extension.provides = org.ovirt.engine.api.extensions.aaa.Authn
ovirt.engine.aaa.authn.profile.name = qa.lab.tlv.redhat.com
ovirt.engine.aaa.authn.authz.plugin = qa.lab.tlv.redhat.com-authz

3. restart ovirt

Actual results:
There is only one qa.lab.tlv. configuration

Expected results:
There are both configurations.

Additional info:
Comment 1 Alon Bar-Lev 2015-01-13 13:04:36 UTC 
this is not a bug, the legacy profiles are extensions just like any other, their name is unique as any other extension.
Comment 2 Alon Bar-Lev 2015-01-13 13:06:28 UTC 
you should see the following message in log:

Could not load the configuration '%1$s' from file %2$s. A configuration with the same name was already loaded from file %3$s"

file name will probably be N/A as this is internally generated.
Comment 3 Ondra Machacek 2015-01-13 13:16:12 UTC 
Created attachment 979617 [details]
engine.log

I don't see it in log.
Comment 4 Alon Bar-Lev 2015-01-13 13:22:10 UTC 
oh!
sorry, I misread...

you have conflict with profile name... last wins, no warning in this regard.

we can probably add one, I do not think it is critical as sysadmin will handle this anyway.
Comment 5 Ondra Machacek 2015-01-13 13:32:13 UTC 
Yes, it's not critical, but it can help to find, where he has mistake in config.
Comment 6 Alon Bar-Lev 2015-01-13 13:32:36 UTC 
Let's fix the warning.
Comment 7 Sandro Bonazzola 2015-01-15 14:15:04 UTC 
This is an automated message: 
This bug should be fixed in oVirt 3.5.1 RC1, moving to QA
Comment 8 Sandro Bonazzola 2015-01-21 16:05:46 UTC 
oVirt 3.5.1 has been released. If problems still persist, please make note of it in this bug report.
Comment 9 Eyal Edri 2015-02-26 12:32:21 UTC 
this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.
Comment 10 Ondra Machacek 2015-03-02 12:21:13 UTC 
2015-03-02 13:19:30,308 WARN  [org.ovirt.engine.core.aaa.AuthenticationProfileRepository] (ServerService Thread Pool -- 49) Profile name 'brq-ipa.rhev.lab.eng.brq.redhat.com' already registered for 'brq-ipa.rhev.lab.eng.brq.redhat.com-authn', ignoring for 'builtin-authn-brq-ipa.rhev.lab.eng.brq.redhat.com'
Comment 11 Sandro Bonazzola 2015-09-04 12:48:04 UTC 
This is an automated message.
oVirt 3.5.4 has been released on September 3rd 2015 and should include the fix for this BZ. Moving to closed current release.
Note You need to log in before you can comment on or make changes to this bug.