Bug 1183462
| Summary: | [ja_JP] [es_ES] [User Portal] String broken in 'New or Edit Network Interface' dialog. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Lijun Li <lijli> | ||||||||||||||
| Component: | ovirt-engine | Assignee: | Marcin Mirecki <mmirecki> | ||||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yuko Katabami <ykatabam> | ||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||
| Priority: | low | ||||||||||||||||
| Version: | 3.5.0 | CC: | alkaplan, bazulay, danken, dkenigsb, ehildesh, gklein, lsurette, mburman, mmirecki, nyechiel, qe-i18n-bugs, rbalakri, Rhev-m-bugs, sbonazzo, srevivo, ykaul, ylavi | ||||||||||||||
| Target Milestone: | ovirt-3.6.2 | Keywords: | i18n, UserExperience | ||||||||||||||
| Target Release: | 3.6.2 | Flags: | ylavi:
Triaged+
|
||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||
| Last Closed: | 2016-04-20 01:37:13 UTC | Type: | Bug | ||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||
| Embargoed: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Lijun Li
2015-01-19 07:13:15 UTC
Created attachment 981343 [details]
[ja_JP][es_ES] [User Portal] String broken in 'New or Edit Network Interface' dialog
*** Bug 1183458 has been marked as a duplicate of this bug. *** The Component of this BZ is web-admin, however the steps to reproduce mention that the dialog was opened from the user-portal - this doesn't matter much, since AFAIK it's the exact same dialog that is opened in the web-admin as well as the user portal (hence, closed duplicate bug 1183458). Created attachment 983109 [details]
'New Network Interface' dialog - improvement suggestion
personally, I don't think that it is looking that bad (marking as Improvement); leaving the decision whether to fix this issue or not to the 'network' team. there are a couple of option for fixing this issue: - allocating more real-estate to the field-labels (either at the expense of the field-inputs or along with extending the width of the dialog). - [my personal preference] better-align the entire dialog to a standard horizontal layout (I elaborated a little bit about it in bug 1166055, comment #1) as depicted in attachment 983109 [details]; this way, the layout is a simple two-column layout of field-label and field-input, and it is as localization-friendly as possible in a horizontal-form-layout dialog such as ours. 'needinfo'ing Eldan as well for his opinion (cannot recall whether he already had an improvement suggestion for this dialog or not). Einav's solution works the best for multi lingual text. I will change one of the icons so it will look align with the other (attached is a rough example). If it's ok with u guys - I will remake the icon accordingly. Created attachment 984584 [details]
same width icon
All referenced patches are merged, shouldn't this be on modified? (In reply to Sandro Bonazzola from comment #9) > All referenced patches are merged, shouldn't this be on modified? Yes! Hi, I think this bug should be failedQa or a new one should be opened, because on chrome the new design/the fix for 'New or Edit Network Interface' dialog is completely broken and doesn't look good. On firefox the new design looks OK. Attaching screenshots. Created attachment 1100104 [details]
screenshots
(In reply to Michael Burman from comment #11) > Hi, > > I think this bug should be failedQa or a new one should be opened, because > on chrome the new design/the fix for 'New or Edit Network Interface' dialog > is completely broken and doesn't look good. > > On firefox the new design looks OK. > > Attaching screenshots. I agree, since we want the application to look reasonable on Chrome for 3.6. Network team should decide how to proceed. Hi Dan, Please reply to the need info in order to decide how to continue here, thank you) See comment 11 ^^ On Chrome, field names are cut. On both browsers, the custom mac address slips off the right hand side of the dialog, and a horizontal scroll bar shows at the bottom. These issues should be fixed. I checked this only on firefox. Needs to be redone. Can you please also check: https://bugzilla.redhat.com/show_bug.cgi?id=1291146 It should be fixed by this patch Created attachment 1131346 [details]
ja-JP fixed
Created attachment 1131347 [details]
es-ES fixed
Tested on 3.6.2.6-0.1.el6 and confirmed that the text is now shown in single line in Chrome for both ja-JP and es-ES. Moving the status to VERIFEID> |