Bug 1183547 - glfs_set_volfile_server() should accept NULL as transport
Summary: glfs_set_volfile_server() should accept NULL as transport
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: mainline
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Niels de Vos
QA Contact: Sudhir D
URL:
Whiteboard:
Depends On:
Blocks: 1044648 1152617 1184358
TreeView+ depends on / blocked
 
Reported: 2015-01-19 09:31 UTC by Niels de Vos
Modified: 2015-05-14 17:45 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1184358 (view as bug list)
Environment:
Last Closed: 2015-05-14 17:29:02 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2015-01-19 09:31:36 UTC
Description of problem:
The documentation of glfs_set_volfile_server() mentions that transport may be passed as a NULL value. However, this is not handled correctly and the function will return EINVAL.

Version-Release number of selected component (if applicable):
Current mainline, and older versions.

How reproducible:
100%

Steps to Reproduce:
1. pass transport=NULL to glfs_set_volfile_server()

Actual results:
glfs_set_volfile_server() returns an error (EINVAL).

Expected results:
Default values for transport should be used, and connecting to the volume should work.

Comment 1 Anand Avati 2015-01-19 10:18:05 UTC
REVIEW: http://review.gluster.org/9464 (gfapi: allow transport=NULL for set_volfile_server()) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2015-01-20 20:39:59 UTC
COMMIT: http://review.gluster.org/9464 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit cdb3fa6088957ed257bfe2c3af59a80033cb2cbb
Author: Niels de Vos <ndevos>
Date:   Mon Jan 19 11:17:20 2015 +0100

    gfapi: allow transport=NULL for set_volfile_server()
    
    Users of gfapi should not need to care about the supported transport
    methods, this is an advanced option. Simple use-cases for libgfapi
    should be able to pass NULL as transport, and the libraries should take
    care of connecting to the Gluster server(s) correctly.
    
    BUG: 1183547
    Change-Id: Id93f96a3d10ae9fb69d53192642145ba8deed863
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9464
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Niels de Vos 2015-05-14 17:29:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:49 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:11 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:45:47 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.