Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1184358

Summary: glfs_set_volfile_server() should accept NULL as transport
Product: [Community] GlusterFS Reporter: Niels de Vos <ndevos>
Component: libgfapiAssignee: bugs <bugs>
Status: CLOSED NEXTRELEASE QA Contact: Sudhir D <sdharane>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.6.1CC: bugs
Target Milestone: ---Keywords: EasyFix, Patch, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1183547 Environment:
Last Closed: 2016-08-30 12:43:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1183547    
Bug Blocks:    

Description Niels de Vos 2015-01-21 07:58:53 UTC 
+++ This bug was initially created as a clone of Bug #1183547 +++

Description of problem:
The documentation of glfs_set_volfile_server() mentions that transport may be passed as a NULL value. However, this is not handled correctly and the function will return EINVAL.

Version-Release number of selected component (if applicable):
Current mainline, and older versions.

How reproducible:
100%

Steps to Reproduce:
1. pass transport=NULL to glfs_set_volfile_server()

Actual results:
glfs_set_volfile_server() returns an error (EINVAL).

Expected results:
Default values for transport should be used, and connecting to the volume should work.

--- Additional comment from Anand Avati on 2015-01-19 11:18:05 CET ---

REVIEW: http://review.gluster.org/9464 (gfapi: allow transport=NULL for set_volfile_server()) posted (#1) for review on master by Niels de Vos (ndevos)

--- Additional comment from Anand Avati on 2015-01-20 21:39:59 CET ---

COMMIT: http://review.gluster.org/9464 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit cdb3fa6088957ed257bfe2c3af59a80033cb2cbb
Author: Niels de Vos <ndevos>
Date:   Mon Jan 19 11:17:20 2015 +0100

    gfapi: allow transport=NULL for set_volfile_server()
    
    Users of gfapi should not need to care about the supported transport
    methods, this is an advanced option. Simple use-cases for libgfapi
    should be able to pass NULL as transport, and the libraries should take
    care of connecting to the Gluster server(s) correctly.
    
    BUG: 1183547
    Change-Id: Id93f96a3d10ae9fb69d53192642145ba8deed863
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9464
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Shyamsundar Ranganathan <srangana>
Comment 1 Niels de Vos 2016-08-30 12:43:32 UTC 
This bug is being closed as GlusterFS-3.6 is nearing its End-Of-Life and only important security bugs will be fixed. This bug has been fixed in more recent GlusterFS releases. If you still face this bug with the newer GlusterFS versions, please open a new bug.