Bug 1186388 - [TEXT][HE] Ask user to choose an existing cluster during installation
Summary: [TEXT][HE] Ask user to choose an existing cluster during installation
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-hosted-engine-setup
Version: 3.6.0
Hardware: x86_64
OS: Linux
medium
high
Target Milestone: ovirt-4.0.0-alpha
: 4.0.0
Assignee: Lev Veyde
QA Contact: Nikolai Sednev
URL:
Whiteboard:
Depends On: 1320964 1325677
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-01-27 15:22 UTC by Nikolai Sednev
Modified: 2019-07-16 11:30 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, the user was always asked to select a cluster name, even when only was available. This prompt was redundant and could be confusing to the user. Now, the code has been modified to automatically select a cluster if there is only one available and the user is no longer prompted for a cluster name if only one is available.
Clone Of:
Environment:
Last Closed: 2016-08-23 21:00:19 UTC
oVirt Team: Integration
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
logs (1.18 KB, application/x-gzip)
2015-01-27 15:26 UTC, Nikolai Sednev
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:1744 0 normal SHIPPED_LIVE ovirt-hosted-engine-setup bug fix and enhancement update for RHV 4.0 2016-09-02 21:30:53 UTC
oVirt gerrit 53840 0 master MERGED add_host: don't ask for cluster name if there is just one 2016-03-14 16:50:00 UTC

Description Nikolai Sednev 2015-01-27 15:22:10 UTC
Description of problem:
Impossible to give different host-cluster name for host on which hosted engine is deployed.

ommand:
          virsh -c qemu+tls://Test/system console HostedEngine
          If you need to reboot the VM you will need to start it manually using the command:
          hosted-engine --vm-start
          You can then set a temporary password using the command:
          hosted-engine --add-console-password
          Please install and setup the engine in the VM.
          You may also be interested in subscribing to "agent" RHN/Satellite channel and installing rhevm-guest-agent-common package in the VM.
          To continue make a selection from the options below:
          (1) Continue setup - engine installation is complete
          (2) Power off and restart the VM
          (3) Abort setup
          (4) Destroy VM and abort setup

          (1, 2, 3, 4)[1]:
[ INFO  ] Engine replied: DB Up!Welcome to Health Status!
          Enter the name of the cluster to which you want to add the host (Default) [Default]: HC_RHEL_6_6
[ ERROR ] Invalid value
          Enter the name of the cluster to which you want to add the host (Default) [Default]: HCRHEL6-6
[ ERROR ] Invalid value
          Enter the name of the cluster to which you want to add the host (Default) [Default]: HCRHEL6
[ ERROR ] Invalid value
          Enter the name of the cluster to which you want to add the host (Default) [Default]: hc_rhel_6_6
[ ERROR ] Invalid value
          Enter the name of the cluster to which you want to add the host (Default) [Default]:
[ INFO  ] Waiting for the host to become operational in the engine. This may take several minutes...
[ INFO  ] Still waiting for VDSM host to become operational...

Version-Release number of selected component (if applicable):
vdsm-4.16.8.1-6.el6ev.x86_64
sanlock-2.8-1.el6.x86_64
libvirt-client-0.10.2-46.el6_6.2.x86_64
ovirt-hosted-engine-ha-1.2.4-5.el6ev.noarch
mom-0.4.1-4.el6ev.noarch
qemu-kvm-rhev-0.12.1.2-2.448.el6.x86_64
ovirt-hosted-engine-setup-1.2.1-9.el6ev.noarch
rhevm-guest-agent-common-1.0.10-2.el6ev.noarch
rhevm-3.5.0-0.30.el6ev.noarch

How reproducible:
100%

Steps to Reproduce:
1.Run on single RHEL6.6 host the "hosted-engine --deploy" procedure.
2.After installation of the RHEVM finished, continue with the deployment procedure untill you have prompt of giving name to cluster.
3.Try giving different names to the name of the cluster to which you want to add the host (Default) [Default]: HC_RHEL_6_6 or HCRHEL6-6 or HCRHEL6 or hc_rhel_6_6

Actual results:
[ ERROR ] Invalid value

Expected results:
Name of the cluster have to be editable.

Additional info:

Comment 1 Nikolai Sednev 2015-01-27 15:26:59 UTC
Created attachment 984720 [details]
logs

Comment 2 Sandro Bonazzola 2015-02-03 13:03:45 UTC
Nikolai, does any of HC_RHEL_6_6 or HCRHEL6-6 or HCRHEL6 or hc_rhel_6_6 exists in the engine?
If not you can't add the host to a non existent cluster.

Comment 3 Nikolai Sednev 2015-02-03 15:54:02 UTC
(In reply to Sandro Bonazzola from comment #2)
> Nikolai, does any of HC_RHEL_6_6 or HCRHEL6-6 or HCRHEL6 or hc_rhel_6_6
> exists in the engine?
> If not you can't add the host to a non existent cluster.

I was trying to add the name of then not existing host clusters, but I don't see any reason of not letting the customer to create a different name, as Default host cluster also does not exists, if taking your comment #2, then Default also should not be added.

Comment 4 Sandro Bonazzola 2015-02-03 15:59:32 UTC
Nikolay, Default is not added, Default just exists.

Comment 5 Nikolai Sednev 2015-02-03 16:08:31 UTC
(In reply to Sandro Bonazzola from comment #4)
> Nikolay, Default is not added, Default just exists.

Might be "Default" be changed to "Any desired host cluster name" chosen by customer, I mean simply renamed?
User was not told that "Default" already exists, message says to choose the name with "Default" as an option only, without any additional information.

Comment 6 Sandro Bonazzola 2015-02-03 16:14:00 UTC
As far as I remember, the setup tool list all existing clusters in the running engine. So if you create 10 clusters in the engine before continuing the setup with
(1) Continue setup - engine installation is complete

it should list all of them and pick one of them (if I remember correctly the first in alphabetical order) as default.

You should see something like:

[ INFO  ] Engine replied: DB Up!Welcome to Health Status!
          Enter the name of the cluster to which you want to add the host (Default, HC_RHEL_6_6, HC_RHEL_7_0) [Default]:

Comment 7 Nikolai Sednev 2015-02-03 16:31:25 UTC
(In reply to Sandro Bonazzola from comment #6)
> As far as I remember, the setup tool list all existing clusters in the
> running engine. So if you create 10 clusters in the engine before continuing
> the setup with
> (1) Continue setup - engine installation is complete
> 
> it should list all of them and pick one of them (if I remember correctly the
> first in alphabetical order) as default.
> 
> You should see something like:
> 
> [ INFO  ] Engine replied: DB Up!Welcome to Health Status!
>           Enter the name of the cluster to which you want to add the host
> (Default, HC_RHEL_6_6, HC_RHEL_7_0) [Default]:
The problem is for the single host that being added for the first time ever.

Comment 8 Sandro Bonazzola 2015-03-23 11:40:19 UTC
(In reply to Nikolai Sednev from comment #5)
> (In reply to Sandro Bonazzola from comment #4)
> > Nikolay, Default is not added, Default just exists.
> 
> Might be "Default" be changed to "Any desired host cluster name" chosen by
> customer, I mean simply renamed?
> User was not told that "Default" already exists, message says to choose the
> name with "Default" as an option only, without any additional information.


I'm not sure to follow.
when you install a clean RHEV system, you ends with a datacenter called "Default" with a cluster called "Default".

When you add HC_RHEL_6_6 and HC_RHEL_7_0 clusters you see that Default exists.

If you specify any non existent name in the setup as in original description it can't work at all.
I'm closing as not a bug, please reopen if you can describe the user interaction you're expecting here.

Comment 9 Nikolai Sednev 2015-03-23 12:06:49 UTC
Customer doesn't know what should be the name, actually he may choose any name to be assigned to the cluster, at least he is not limited by the message to any specific cluster name, hence if system has predefined host cluster name, it's not explained or understandable. thus customer may try to give any name to host cluster and will end up with error, I'd expect that system will change the host cluster name following customer decision taken during the deployment.


[ INFO  ] Engine replied: DB Up!Welcome to Health Status!                                                                                                  
          Enter the name of the cluster to which you want to add the host (Default) [Default]:                                                             
[ INFO  ] Waiting for the host to become operational in the engine. This may take several minutes...

Comment 10 Sandro Bonazzola 2015-03-23 12:23:56 UTC
(In reply to Nikolai Sednev from comment #9)
> Customer doesn't know what should be the name, actually he may choose any
> name to be assigned to the cluster, at least he is not limited by the
> message to any specific cluster name, hence if system has predefined host
> cluster name, it's not explained or understandable. thus customer may try to
> give any name to host cluster and will end up with error, I'd expect that
> system will change the host cluster name following customer decision taken
> during the deployment.
> 
> 
> [ INFO  ] Engine replied: DB Up!Welcome to Health Status!                   
> 
>           Enter the name of the cluster to which you want to add the host
> (Default) [Default]:                                                        
> 
> [ INFO  ] Waiting for the host to become operational in the engine. This may
> take several minutes...

So you're asking an RFE to create the cluster if the cluster with given name does not exist?

Comment 11 Nikolai Sednev 2015-03-23 12:56:46 UTC
(In reply to Sandro Bonazzola from comment #10)
> (In reply to Nikolai Sednev from comment #9)
> > Customer doesn't know what should be the name, actually he may choose any
> > name to be assigned to the cluster, at least he is not limited by the
> > message to any specific cluster name, hence if system has predefined host
> > cluster name, it's not explained or understandable. thus customer may try to
> > give any name to host cluster and will end up with error, I'd expect that
> > system will change the host cluster name following customer decision taken
> > during the deployment.
> > 
> > 
> > [ INFO  ] Engine replied: DB Up!Welcome to Health Status!                   
> > 
> >           Enter the name of the cluster to which you want to add the host
> > (Default) [Default]:                                                        
> > 
> > [ INFO  ] Waiting for the host to become operational in the engine. This may
> > take several minutes...
> 
> So you're asking an RFE to create the cluster if the cluster with given name
> does not exist?

I'm not asking for RFE, user does not knows for if "default" host cluster even exists... Our code already has default host cluster, but the naming convention is up to user to define... Either changing the default host cluster name of information message will do the work here, please decide on which one you would like to stick with, IMHO naming solution have to be flexible until defined differently in any documentation.

Comment 12 Lev Veyde 2015-03-23 14:17:36 UTC
I think that the question should be removed entirely in case we only have one cluster, as it doesn't make much sense to ask the user a question, which has only one possible answer. The value should be saved to the answer file though.

In case there are more than one cluster, then the prompt should be clear enough to indicate that the question is a selection is from a closed list, not an open one.

My suggestion is to i.e. modify the word "enter" by "select", so it will be something like:

Please select the cluster to which you want to add the host (Default, HACluster, XeonCluster) [Default]:

Comment 13 Sandro Bonazzola 2015-03-23 14:23:33 UTC
Nikolai, can you ack Lev's comment #12?

Comment 14 Nikolai Sednev 2015-03-24 08:07:28 UTC
(In reply to Sandro Bonazzola from comment #13)
> Nikolai, can you ack Lev's comment #12?

ACK, if there is no other options, no need to display anything, but if there are some additional host clusters detected on storage, only then message have to be displayed and customer have to select the desired host cluster for host to join in.

Comment 16 Nikolai Sednev 2016-04-10 15:40:13 UTC
I've attempted the NFS based HE deployment using ovirt-engine-appliance.noarch 0:4.0-20160322.1.el7.centos from disk and failed with:
"[ INFO  ] Connecting to the Engine
[ ERROR ] Cannot automatically add the host to cluster Default:  <html><head><title>Error</title></head><body>Internal Server Error</body></html> 
         
         
          Please check Engine VM configuration.
         
          Make a selection from the options below:
          (1) Continue setup - Engine VM configuration has been fixed
          (2) Abort setup
         
          (1, 2)[1]: 
"

HE deployment did not asked user to manually enter "Default" host cluster during deployment on first host, as there was no other host clusters available, except the "Default", so for me this very bug is resolved and I've opened a new https://bugzilla.redhat.com/show_bug.cgi?id=1325677 for deployment issue. 

Components on host:

qemu-kvm-rhev-2.3.0-31.el7_2.11.x86_64
libvirt-client-1.2.17-13.el7_2.4.x86_64
vdsm-4.17.999-817.git03d82f6.el7.centos.noarch
mom-0.5.2-0.0.master.20160226114234.git95535d1.el7.noarch
sanlock-3.2.4-2.el7_2.x86_64
ovirt-hosted-engine-ha-2.0.0-0.0.master.20160321143043.20160321143039.gitadbef4c.el7.noarch
ovirt-setup-lib-1.0.2-0.0.master.20160119215211.gita8bd5cb.el7.centos.noarch
ovirt-vmconsole-1.0.1-0.0.master.20160309100203.gitdfa3c40.el7.noarch
ovirt-release40-4.0.0-0.2.alpha1.20160405123556.gitbd184ec.noarch
libgovirt-0.3.3-1.el7_2.1.x86_64
ovirt-vmconsole-host-1.0.1-0.0.master.20160309100203.gitdfa3c40.el7.noarch
ovirt-engine-sdk-python-3.6.3.1-0.1.20160211.git13845c8.el7.centos.noarch
ovirt-hosted-engine-setup-2.0.0-0.0.master.20160318071154.gite339fa9.el7.centos.noarch
ovirt-host-deploy-1.5.0-0.0.master.20160317100615.gitf913ead.el7.noarch

Red Hat Enterprise Linux Server release 7.2 (Maipo)
Linux 3.10.0-327.13.1.el7.x86_64 #1 SMP Mon Feb 29 13:22:02 EST 2016 x86_64 x86_64 x86_64 GNU/Linux

Comment 18 errata-xmlrpc 2016-08-23 21:00:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-1744.html


Note You need to log in before you can comment on or make changes to this bug.