The engine-backup procedure should add events straight to the database either on success, or on failure (no need for "started" as the backup process should be fast, even on large datacenters). The failure/success should come with a message as well, that will be put in the events table, and should contain the message (with the log path, for example).

*** Bug 1188140 has been marked as a duplicate of this bug. ***

(In reply to Yaniv Dary from comment #1)
> The engine-backup procedure should add events straight to the database
> either on success, or on failure (no need for "started" as the backup
> process should be fast, even on large datacenters). The failure/success
> should come with a message as well, that will be put in the events table,
> and should contain the message (with the log path, for example).

This is Oved note on this. I would still add start event and have a completion\failure with log location in the event.

Oved,
can you please add the relevant events to the wiki page?

see
www.ovirt.org/Features/BackupAwareness
 Interface to engine-backup 
 Events Raised

Some questions:

1. Should engine-backup do something different for this bug and for bug 1188124? Or just call LogEngineBackupEvent (once at start, once at end - either successful or failed) for both of them? Just close one as a duplicate of the other?

2. This bug asks for the log path. Where should it be written? Perhaps add a column for this?

3. What's the 'db_name' for? Is this the engine's database name? In particular, if it backs up also dwh/reports (and files), do we want this logged? Separately?

(In reply to Yedidyah Bar David from comment #6)
> Some questions:
> 
> 1. Should engine-backup do something different for this bug and for bug
> 1188124? Or just call LogEngineBackupEvent (once at start, once at end -
> either successful or failed) for both of them? Just close one as a duplicate
> of the other?

Yes, please close as duplicate 

> 
> 2. This bug asks for the log path. Where should it be written? Perhaps add a
> column for this?


Please elaborate, if there is any log it is the engine-backup log, I see no other log involved 

> 
> 3. What's the 'db_name' for? Is this the engine's database name? In
> particular, if it backs up also dwh/reports (and files), do we want this
> logged? Separately?

db_name currently is 'engine' or whatever will be decided in order to recognize DWH backups , we added this to support this feature also on history backups so it is not related to the real database name

*** Bug 1188124 has been marked as a duplicate of this bug. ***

(In reply to Eli Mesika from comment #7)
> (In reply to Yedidyah Bar David from comment #6)
> > Some questions:
> > 
> > 1. Should engine-backup do something different for this bug and for bug
> > 1188124? Or just call LogEngineBackupEvent (once at start, once at end -
> > either successful or failed) for both of them? Just close one as a duplicate
> > of the other?
> 
> Yes, please close as duplicate 

Done, thanks

> 
> > 
> > 2. This bug asks for the log path. Where should it be written? Perhaps add a
> > column for this?
> 
> 
> Please elaborate, if there is any log it is the engine-backup log, I see no
> other log involved 

Yes, the log of engine-backup. We want to log it. Where?

> 
> > 
> > 3. What's the 'db_name' for? Is this the engine's database name? In
> > particular, if it backs up also dwh/reports (and files), do we want this
> > logged? Separately?
> 
> db_name currently is 'engine' or whatever will be decided in order to
> recognize DWH backups , we added this to support this feature also on
> history backups so it is not related to the real database name

We already support dwh/reports in engine-backup, but it was not requested to monitor them, see bug 1188119 comment 3 and later.

So currently just log the engine's db backup with the fixed string 'engine'?

(In reply to Yedidyah Bar David from comment #9)
> Yes, the log of engine-backup. We want to log it. Where?

In the same place you log without this feature , why it should be changed ?

> 

> So currently just log the engine's db backup with the fixed string 'engine'?

Right

Current status of the patch [1]:

1. It always notifies on backup start and finish, regardless of scope (see bug 1188119 comment 6).

2. It always notifies only status, log file full path, and time (and the string 'engine'). Never anything else, including error messages, scope, etc. These all can be found in the log file.

AFAIAC it's ready.

I'd personally prefer to pass more data, including scope, error message etc., but this requires doing some (what seems to be) significant changes in the db/interface/engine, so can probably wait.

Comments are welcome, here or in gerrit.

[1] https://gerrit.ovirt.org/40128

(In reply to Yedidyah Bar David from comment #11)

> I'd personally prefer to pass more data, including scope, error message
> etc., but this requires doing some (what seems to be) significant changes in
> the db/interface/engine, so can probably wait.
Didi, if we will decide to add the log path, I would like to add any other required field in the same phase since it will take me less time to add whatever we need instead of adding any other additional fields in future 

What other fields except of the log path do you think we should add ???

In a private discussion we agreed to:

1) add a field log_path - this will be the full path to the log file

2) add a field fqdn - fqdn of the host running engine-backup (and therefore having the log file).

Note that a remote machine might or might not be able to update the engine db, so this cannot be relied upon currently for monitoring backups of remote dwh/reports. Specifically a Reports-only machine does not have access to the engine db.

3) rename db_name to scope, can be one of the following values {db,dwhdb,reportsdb,files}

We will save a record per scope , that means that if db and files were backed up, two call for LogEngineBackupEvent will be issues one with 'db' as scope and one with 'files' as scope.

Setting needinfo on Eli for code update of db side...

http://www.ovirt.org/Features/BackupAwareness#Interface_to_engine-backup

set doc text -, we have a feature page for this

Verified with:
ovirt-engine-3.6.0-0.0.master.20150623052342.gita7865c8.el6.noarch

According to what's described in http://www.ovirt.org/Features/BackupAwareness messages for start/finish/failure of engine-backup are displayed under event log.

oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.